FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix `filename` type in `watch` result by Semigradsky · Pull Request #48032 · nodejs/node · GitHub

/ node Public

doc: fix filename type in watch result - #48032

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Semigradsky:fix-watch-filename
Jun 23, 2023
Merged

doc: fix filename type in watch result#48032
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Semigradsky:fix-watch-filename

Conversation

Copy link
Copy Markdown
Contributor

By doc:

Providing filename argument in the callback is only supported on Linux,
macOS, Windows, and AIX. Even on supported platforms, filename is not always
guaranteed to be provided. Therefore, don't assume that filename argument is
always provided in the callback, and have some fallback logic if it is null.

So I added null to type to do it more clearly

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 16, 2023

ghost commented May 28, 2023

Copy link
Copy Markdown

Merged on @types/node

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
nodejs-github-bot merged commit 9b61322 into nodejs:main Jun 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9b61322

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL