build: add action to close stale PRs - #48051
Conversation
Sorry, something went wrong.
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Review requested:
|
Sorry, something went wrong.
|
We currently have over 195 pull requests which were created more than a year ago and (up from 117 a year ago). Most of those have not had an update/comments for over 6 months. This PR adds an action which will mark pull requests older than 1 year as stale once there have been no comments/updates for 5 months and then close them after another month if that does not trigger any comments. I think this will help us lower the backlog of PRs (430 right) now) and in particular by helping close those which are very unlikely to land. A simple comment is all it takes to reset the PR so that it won't be closed if that is the right thing to do. I had to add a new option to actions/stale to support the 1 year old check (end date - actions/stale#1013) so this uses my version of that action until we get the updated landed in actions/stale. The current action also requires PRs to be tagged with the test-stale-pr lable so that it will only work on PRs on which that lable is added. I'll use that to slowly add to the list of PRs that will be processed by the new action. Once we are confident it's working ok I'll then add the tag to a few batches a week so that we don't get too many notifications all at once. Once all PRs that are currently stale are processed I'll then remove the requirement for that lable in a follow on PR and we will be at steady state where PRs get processed as they reach the 1year old and 6 months without any updates point. |
Sorry, something went wrong.
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
|
Can this be a modification of .github/workflows/close-stalled.yml rather than creating a new job? We already have that and .github/workflows/close-stale-feature-requests.yml and I would rather have these things consolidated into a single action rather than spread out like this. (And if we need to have multiple actions, let's name them clearly. I would think close-stalled would handle stalled PRs, but if not, then let's rename it.) |
Sorry, something went wrong.
mcollina
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
|
@Trott testing actions is a bit difficult and I'd be a bit worried that by combining in I might break the existing action or cause issues we don't want to be processed covered. If we want to consolidate then maybe we can do that as a follow on step as we already have more than one action handling stale issues. |
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@nodejs/tsc FYI that I plan to land this in the next day or so unless there are comments/objections. |
Sorry, something went wrong.
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48196 Reviewed-By: Mestery <mestery@protonmail.com>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48196 Reviewed-By: Mestery <mestery@protonmail.com>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48196 Reviewed-By: Mestery <mestery@protonmail.com>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48196 Reviewed-By: Mestery <mestery@protonmail.com>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48196 Reviewed-By: Mestery <mestery@protonmail.com>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months.
Fixes: #42981