doc: harmonize fenced code snippet flags - #48082
Merged
aduh95 merged 1 commit intoMay 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Trott
approved these changes
May 19, 2023
Copy link
Copy Markdown
Member
|
There are still a few one liners in BUILDING.md, e.g. Lines 324 to 326 in da31b4d |
Sorry, something went wrong.
RaisinTen
approved these changes
May 20, 2023
ShogunPanda
approved these changes
May 20, 2023
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
lpinca
approved these changes
May 21, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48082 ✔ Done loading data for nodejs/node/pull/48082 ----------------------------------- PR info ------------------------------------ Title doc: harmonize fenced code snippet flags (#48082) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:single-console -> nodejs:main Labels doc, fast-track, author ready Commits 3 - doc: remove single-line console code snippets - fix remaining snippets - fixup! fix remaining snippets Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48082 Reviewed-By: Rich Trott Reviewed-By: Darshan Sen Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48082 Reviewed-By: Rich Trott Reviewed-By: Darshan Sen Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 19 May 2023 22:18:29 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48082#pullrequestreview-1435267728 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48082#pullrequestreview-1435362293 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/48082#pullrequestreview-1435416759 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48082#pullrequestreview-1435475223 ℹ This PR is being fast-tracked ✘ This PR needs to wait 16 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5036077796 |
Sorry, something went wrong.
We had a few code snippets that were using a non-descriptive tag (e.g. `console` or `text`), whereas the actual language it's using describes it better, and improves the syntax highlighting. This commit also removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it easier for readers to copy and paste to try the command themselves. PR-URL: nodejs#48082 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
We had a few code snippets that were using a non-descriptive tag (e.g. `console` or `text`), whereas the actual language it's using describes it better, and improves the syntax highlighting. This commit also removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it easier for readers to copy and paste to try the command themselves. PR-URL: #48082 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
We had a few code snippets that were using a non-descriptive tag (e.g. `console` or `text`), whereas the actual language it's using describes it better, and improves the syntax highlighting. This commit also removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it easier for readers to copy and paste to try the command themselves. PR-URL: nodejs#48082 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
We had a few code snippets that were using a non-descriptive tag (e.g. `console` or `text`), whereas the actual language it's using describes it better, and improves the syntax highlighting. This commit also removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it easier for readers to copy and paste to try the command themselves. PR-URL: nodejs#48082 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a few code snippets that were using a non-descriptive tag (e.g. console or text), whereas the actual language it's using describes it better, and improves the syntax highlighting. This PR also removes non-necessary leading chars (e.g. $, >, or %) to make it easier for readers to copy and paste to try the command themselves.
/cc @alexsch01