FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: fix test deserialize edge cases by MoLow · Pull Request #48106 · nodejs/node · GitHub

/ node Public

test_runner: fix test deserialize edge cases - #48106

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-deserialize
May 23, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: fix test deserialize edge cases#48106
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-deserialize

Conversation

MoLow commented May 21, 2023

Copy link
Copy Markdown
Member

Fixes: #48103

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 21, 2023
MoLow requested a review from cjihrig May 22, 2023 15:51
cjihrig approved these changes May 22, 2023
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Outdated
Comment thread test/parallel/test-runner-v8-deserializer.mjs Outdated
Comment thread test/parallel/test-runner-v8-deserializer.mjs Outdated
Comment thread test/parallel/test-runner-v8-deserializer.mjs Outdated
Comment thread test/parallel/test-runner-v8-deserializer.mjs Outdated
Comment thread test/parallel/test-runner-v8-deserializer.mjs Outdated
Comment thread lib/internal/test_runner/runner.js Outdated
Comment thread lib/internal/test_runner/runner.js Outdated

cjihrig commented May 22, 2023

Copy link
Copy Markdown
Contributor

It might be worth adding a note/label on the original PR that moved to V8 serialization that this PR should be backported with it.

MoLow force-pushed the fix-test-deserialize branch from 1b32632 to e669180 Compare May 23, 2023 05:52
MoLow mentioned this pull request May 23, 2023
Merged
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51921/

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51923/

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51924/

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51938/

MoLow requested a review from benjamingr May 23, 2023 17:01
MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 23, 2023
MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
nodejs-github-bot merged commit f0e70ee into nodejs:main May 23, 2023

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in f0e70ee

MoLow deleted the fix-test-deserialize branch May 23, 2023 21:03
This was referenced May 24, 2023
Open
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
test_runner: fix test deserialize edge cases
027c531 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
github-actions Bot mentioned this pull request May 31, 2023
Open
22 tasks
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test_runner: fix test deserialize edge cases
d18b61b 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
test_runner: fix test deserialize edge cases
47602fe 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: fix test deserialize edge cases
697b6bd 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: fix test deserialize edge cases
84b2e49 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test runner v8 serialization fails

4 participants

Back | FazBrowse Home | New Git URL