FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve the documentation of the stdio option by Karnav123 · Pull Request #48110 · nodejs/node · GitHub

/ node Public

doc: improve the documentation of the stdio option - #48110

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Karnav123:patch-1
May 30, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: improve the documentation of the stdio option#48110
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Karnav123:patch-1

Conversation

Karnav123 commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

doc: Add the links to better explain stdio property of cluster.settings in the file doc/api/cluster.md#clustersettings.

Fixes: issue #47705
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings

  • doc

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels May 22, 2023
lpinca reviewed May 25, 2023
View reviewed changes
Comment thread doc/api/cluster.md Outdated
Karnav123 requested a review from lpinca May 25, 2023 19:47
lpinca reviewed May 25, 2023
View reviewed changes
Comment thread doc/api/cluster.md Outdated
Karnav123 changed the title Update cluster.md doc: Update cluster.md May 26, 2023

Karnav123 commented May 28, 2023

Copy link
Copy Markdown
Contributor Author

@lpinca I am sorry for bothering but this PR is not getting included in the CI run. I am not able to understand why?

lpinca commented May 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.

Karnav123 changed the title doc: Update cluster.md doc: improve the documentation of the stdio May 28, 2023
Karnav123 changed the title doc: improve the documentation of the stdio doc: improve the documentation of the stdio option May 28, 2023

Karnav123 commented May 28, 2023

Copy link
Copy Markdown
Contributor Author

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.

Thank you! Done.

lpinca commented May 28, 2023

Copy link
Copy Markdown
Member

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.

Karnav123 commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.

Please rebase and change it.

lpinca added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 29, 2023
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
nodejs-github-bot merged commit 84716d8 into nodejs:main May 30, 2023

nodejs-github-bot commented May 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 84716d8

targos pushed a commit that referenced this pull request May 30, 2023
doc: improve the documentation of the stdio option
8c53386 
Fixes: #47705
PR-URL: #48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
doc: improve the documentation of the stdio option
0eaefd5 
Fixes: #47705
PR-URL: #48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
doc: improve the documentation of the stdio option
f2bb191 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: improve the documentation of the stdio option
e908fef 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: improve the documentation of the stdio option
23f77b7 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL