deps: update c-ares to 1.19.1 by nodejs-github-bot · Pull Request #48115 · nodejs/node · GitHub

This is an automated update of c-ares to 1.19.1.

Review requested:

@nodejs/net

There are new files. We probably need to update the .gyp file.

cc @marco-ippolito

CI: https://ci.nodejs.org/job/node-test-pull-request/51912/

CI: https://ci.nodejs.org/job/node-test-pull-request/51914/

LGTM

Landed in 21153a8

PR-URL: #48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs/node#48115

PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> # Conflicts: # deps/cares/CHANGES # deps/cares/CMakeLists.txt # deps/cares/RELEASE-NOTES # deps/cares/aminclude_static.am # deps/cares/configure # deps/cares/configure.ac # deps/cares/include/ares_version.h # deps/cares/src/lib/Makefile.in # deps/cares/src/lib/ares_data.h # deps/cares/src/lib/ares_destroy.c # deps/cares/src/lib/ares_getaddrinfo.c # deps/cares/src/lib/ares_init.c # deps/cares/src/lib/ares_strsplit.c

PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> # Conflicts: # deps/cares/CHANGES # deps/cares/CMakeLists.txt # deps/cares/RELEASE-NOTES # deps/cares/aminclude_static.am # deps/cares/configure # deps/cares/configure.ac # deps/cares/include/ares_version.h # deps/cares/src/lib/Makefile.in # deps/cares/src/lib/ares_data.h # deps/cares/src/lib/ares_destroy.c # deps/cares/src/lib/ares_getaddrinfo.c # deps/cares/src/lib/ares_init.c # deps/cares/src/lib/ares_strsplit.c

PR-URL: nodejs#48115 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

chore: bump node to v18.16.1 (main) (#38869) * chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

PR-URL: nodejs#48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

* chore: bump node in DEPS to v18.16.1 * chore: update patches * deps: update c-ares to 1.19.1 nodejs/node#48115 * chore: fix -Wunreachable-code,-Werror FTBFS in c-ares * chore: disable x509 bssl test new test added in bf3e2c892 * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix related -Werror,-Wunused-function FTBFS * fixup! chore: fix -Wunreachable-code,-Werror FTBFS in c-ares also fix another related -Werror,-Wunused-function FTBFS * fixup! chore: disable x509 bssl test fix yet another -Werror,-Wunused-function FTBFS --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

PR-URL: nodejs#48115 Backport-PR-URL: nodejs-private/node-private#437 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

deps: update c-ares to 1.19.1

dde500e

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 22, 2023

nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels May 22, 2023

fix: gyp file

1bb54df

targos approved these changes May 22, 2023

View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

RafaelGSS approved these changes May 22, 2023

View reviewed changes

Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 22, 2023

Trott approved these changes May 22, 2023

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2023

This was referenced May 23, 2023

CI Reliability 2023-05-23 nodejs/reliability#574

Open

CI Reliability 2023-05-24 nodejs/reliability#575

Open

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023

nodejs-github-bot merged commit 21153a8 into main May 24, 2023

nodejs-github-bot deleted the actions/tools-update-c-ares branch May 24, 2023 13:27

richardlau added lts-watch-v16.x labels May 24, 2023

github-actions Bot mentioned this pull request May 30, 2023

CI Reliability 2023-05-30 nodejs/reliability#581

Open

23 tasks

targos pushed a commit that referenced this pull request May 30, 2023

deps: update c-ares to 1.19.1

d4922bc

PR-URL: #48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

github-actions Bot mentioned this pull request May 31, 2023

CI Reliability 2023-05-31 nodejs/reliability#582

Open

22 tasks

targos mentioned this pull request Jun 4, 2023

v20.3.0 release proposal #48332

Merged

codebytere added a commit to electron/electron that referenced this pull request Jun 22, 2023

deps: update c-ares to 1.19.1

cc11060

nodejs/node#48115

mxdvl mentioned this pull request Jun 23, 2023

Updated Node To v18.16.1 guardian/dotcom-rendering#8032

Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update c-ares to 1.19.1

7c5ddf7

PR-URL: nodejs#48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update c-ares to 1.19.1

a6627ed

PR-URL: nodejs#48115 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

richardlau added backported-to-v16.x and removed lts-watch-v16.x labels Aug 24, 2023

deps: update c-ares to 1.19.1 by nodejs-github-bot · Pull Request #48115 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: update c-ares to 1.19.1 - #48115

deps: update c-ares to 1.19.1#48115
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-c-ares

nodejs-github-bot commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

targos commented May 22, 2023

Uh oh!

RafaelGSS commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

RafaelGSS left a comment

Uh oh!

nodejs-github-bot commented May 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

deps: update c-ares to 1.19.1 by nodejs-github-bot · Pull Request #48115 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: update c-ares to 1.19.1 - #48115

deps: update c-ares to 1.19.1#48115nodejs-github-bot merged 2 commits intomainnodejs/node:mainfrom actions/tools-update-c-aresnodejs/node:actions/tools-update-c-aresCopy head branch name to clipboard

Conversation

nodejs-github-bot commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

targos commented May 22, 2023

Uh oh!

RafaelGSS commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

nodejs-github-bot commented May 22, 2023

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

deps: update c-ares to 1.19.1#48115
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-c-ares