FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: alphabetize CODEOWNERS by Trott · Pull Request #48124 · nodejs/node · GitHub

/ node Public

tools: alphabetize CODEOWNERS - #48124

Merged
Trott merged 1 commit into
nodejs:mainfrom
Trott:alphabetize-codeowners
May 24, 2023
ConversationCommits (1)ChecksFiles changed
Merged

tools: alphabetize CODEOWNERS#48124
Trott merged 1 commit into
nodejs:mainfrom
Trott:alphabetize-codeowners

Conversation

Trott commented May 22, 2023

Copy link
Copy Markdown
Member

Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists.

nodejs-github-bot commented May 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 22, 2023
Trott mentioned this pull request May 22, 2023
Merged
debadree25 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 23, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 24, 2023

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48124
✔  Done loading data for nodejs/node/pull/48124
----------------------------------- PR info ------------------------------------
Title      tools: alphabetize CODEOWNERS (#48124)
Author     Rich Trott  (@Trott)
Branch     Trott:alphabetize-codeowners -> nodejs:main
Labels     meta, author ready
Commits    1
 - tools: alphabetize CODEOWNERS
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/48124
Reviewed-By: Darshan Sen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Moshe Atlow 
Reviewed-By: Mestery 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48124
Reviewed-By: Darshan Sen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Moshe Atlow 
Reviewed-By: Mestery 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 May 2023 22:28:02 GMT
   ✔  Approvals: 7
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438517385
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438534809
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438575044
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438716308
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438844200
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1439978640
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48124#pullrequestreview-1442604646
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48124
From https://github.com/nodejs/node
 * branch                  refs/pull/48124/merge -> FETCH_HEAD
✔  Fetched commits as ceb2a21edd7b..60d2b0b69501
--------------------------------------------------------------------------------
Auto-merging .github/CODEOWNERS
CONFLICT (content): Merge conflict in .github/CODEOWNERS
error: could not apply 60d2b0b695... tools: alphabetize CODEOWNERS
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/5074032340

Trott force-pushed the alphabetize-codeowners branch from 60d2b0b to a07d3b6 Compare May 24, 2023 23:48
Trott removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 24, 2023
tools: alphabetize CODEOWNERS
bd829f2 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott force-pushed the alphabetize-codeowners branch from a07d3b6 to bd829f2 Compare May 24, 2023 23:49
Trott merged commit bd829f2 into nodejs:main May 24, 2023

Trott commented May 24, 2023

Copy link
Copy Markdown
Member Author

Landed in bd829f2

Trott deleted the alphabetize-codeowners branch May 24, 2023 23:50
targos pushed a commit that referenced this pull request May 30, 2023
tools: alphabetize CODEOWNERS
ad8a688 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: #48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
tools: alphabetize CODEOWNERS
0969206 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: #48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
tools: alphabetize CODEOWNERS
4c5c63f 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
tools: alphabetize CODEOWNERS
3b05ff1 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
tools: alphabetize CODEOWNERS
b26de98 
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
gireeshpunathil gireeshpunathil approved these changes
MoLow MoLow approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL