test: fix flaky test-watch-mode - #48147
Merged
nodejs-github-bot merged 1 commit intoJun 8, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
5 times, most recently
from
fee6ffb to
155d3a0
Compare
May 24, 2023 22:38
MoLow
marked this pull request as ready for review
May 24, 2023 22:44
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 26, 2023
This was referenced Jun 2, 2023
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
from
155d3a0 to
3dfe3ce
Compare
June 7, 2023 20:37
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
marked this pull request as draft
June 8, 2023 04:56
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
3 times, most recently
from
c968d3d to
d68b680
Compare
June 8, 2023 05:46
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
from
d68b680 to
078afb8
Compare
June 8, 2023 06:15
MoLow
marked this pull request as ready for review
June 8, 2023 06:20
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
Jun 8, 2023
This was referenced Jun 11, 2023
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Copy link
Copy Markdown
Member
|
hi @MoLow this is not landing cleanly in v18.x-staging and will need manual backporting. |
Sorry, something went wrong.
ruyadorno
pushed a commit
to MoLow/node
that referenced
this pull request
Sep 7, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #44898
stress tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/402/
also, ran python tools/test.py -J --repeat=500 test/sequential/test-watch-mode locally (macos m1 & windows vm with arm) with no failures