sea: add support for V8 bytecode-only caching by RaisinTen · Pull Request #48191 · nodejs/node · GitHub

This improves the startup performance of SEAs.

For example, the comparison of the startup performance benchmarks of a Node.js SEA built using the CJS bundle of Yarn's source code shows a 24% improvement on my x86_64 macOS:

$ hyperfine -N -w 30 -L cmd 'with_code_cache/yarn help','without_code_cache/yarn help' '{cmd}'
Benchmark 1: with_code_cache/yarn help
  Time (mean ± σ):     210.8 ms ±   1.3 ms    [User: 224.0 ms, System: 25.2 ms]
  Range (min … max):   209.0 ms … 213.4 ms    14 runs

Benchmark 2: without_code_cache/yarn help
  Time (mean ± σ):     279.1 ms ±   2.3 ms    [User: 284.9 ms, System: 30.1 ms]
  Range (min … max):   276.6 ms … 284.4 ms    10 runs

Summary
  'with_code_cache/yarn help' ran
    1.32 ± 0.01 times faster than 'without_code_cache/yarn help'

Fixes: nodejs/single-executable#73

cc @kvakil

Review requested:

@nodejs/loaders
@nodejs/modules
@nodejs/single-executable
@nodejs/startup

I don't think this includes any tests for the new feature? We should at least have some to exercise the code paths..

I don't think this includes any tests for the new feature? We should at least have some to exercise the code paths..

This change generates the code cache and uses it by default, so the existing E2E SEA tests should already be exercising the added code paths, right?

Thanks, this is great! I left some nits

(One last note wrt startup time: it's unfortunate that we store the source code as UTF8 because then we need to transcode/copy it into Latin1/UTF16 in order to actually put it into V8. Ideally we'd use external strings instead. That's not really related to this diff, but thought I'd note it since we're one the subject. :)

it's unfortunate that we store the source code as UTF8 because then we need to transcode/copy it into Latin1/UTF16 in order to actually put it into V8

I think this could be made configurable because storing the strings as UTF8 could save quite some space if the source actually contains two-byte characters, which may be more important to users than the startup cost depending on their use case.

Refs: https://github.com/nodejs/node/pull/48191/files/300f3f4a03d7f418fb565a479f19b67c22d80a07#r1269601154 Signed-off-by: Darshan Sen <raisinten@gmail.com>

Signed-off-by: Darshan Sen <raisinten@gmail.com>

Done @joyeecheung, PTAL

LGTM, thanks

CI: https://ci.nodejs.org/job/node-test-pull-request/52932/

Landed in 6cd6789

Refs: nodejs/single-executable#73 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#48191 Fixes: nodejs/single-executable#73 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs: nodejs/single-executable#73 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #48191 Fixes: nodejs/single-executable#73 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs/node#48191

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 26, 2023

RaisinTen mentioned this pull request May 26, 2023

bytecode-only SEA caching? nodejs/single-executable#73

Closed

anonrig reviewed May 26, 2023

View reviewed changes

Comment thread src/node_sea.cc Outdated

Comment thread src/node_contextify.cc Outdated

Comment thread src/node_sea.cc Outdated

RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 27, 2023

anonrig approved these changes May 27, 2023

View reviewed changes

joyeecheung reviewed May 28, 2023

View reviewed changes

Comment thread lib/internal/util/embedding.js Outdated

jasnell reviewed May 29, 2023

View reviewed changes

Comment thread src/node_contextify.cc Outdated

joyeecheung reviewed May 31, 2023

View reviewed changes

Comment thread src/node_sea.cc Outdated

Qard approved these changes May 31, 2023

View reviewed changes

joyeecheung reviewed Jun 1, 2023

View reviewed changes

Comment thread src/node_sea.cc Outdated

Comment thread lib/internal/modules/cjs/loader.js Outdated

RaisinTen added the single-executable Issues and PRs related to single-executable applications label Jun 2, 2023

RaisinTen commented Jun 2, 2023

View reviewed changes

Comment thread src/node_sea.cc Outdated

aymen94 approved these changes Jun 6, 2023

View reviewed changes

kvakil reviewed Jun 9, 2023

View reviewed changes

Comment thread src/node_contextify.cc Outdated

Comment thread src/node_contextify.cc Outdated

Comment thread src/node_sea.cc Outdated

RaisinTen mentioned this pull request Jun 27, 2023

deps: V8: cherry-pick cb00db4dba6c #48576

Closed

RaisinTen added 2 commits July 21, 2023 12:42

src: remove unnecessary HandleScope

d44aa0d

Refs: https://github.com/nodejs/node/pull/48191/files/300f3f4a03d7f418fb565a479f19b67c22d80a07#r1269601154 Signed-off-by: Darshan Sen <raisinten@gmail.com>

test: fix test/parallel/test-node-output-errors.mjs error

91bf2df

Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen force-pushed the sea-V8-code-cache branch from 300f3f4 to 91bf2df Compare July 21, 2023 07:28

joyeecheung approved these changes Jul 25, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

github-actions Bot mentioned this pull request Jul 26, 2023

CI Reliability 2023-07-26 nodejs/reliability#624

Open

14 tasks

RaisinTen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023

nodejs-github-bot merged commit 6cd6789 into nodejs:main Jul 26, 2023

RaisinTen deleted the sea-V8-code-cache branch July 26, 2023 10:25

github-actions Bot mentioned this pull request Jul 27, 2023

CI Reliability 2023-07-27 nodejs/reliability#625

Open

18 tasks

This was referenced Jul 28, 2023

CI Reliability 2023-07-28 nodejs/reliability#626

Open

CI Reliability 2023-07-29 nodejs/reliability#627

Open

CI Reliability 2023-07-30 nodejs/reliability#628

Open

CI Reliability 2023-07-31 nodejs/reliability#629

Open

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 6, 2023

sea: add support for V8 bytecode-only caching

43c93e2

nodejs/node#48191

robertsLando mentioned this pull request Apr 10, 2026

proposal: bytecode-only script execution via vm module (sourceless mode) #62670

Open

sea: add support for V8 bytecode-only caching by RaisinTen · Pull Request #48191 · nodejs/node · GitHub

Uh oh!

Uh oh!

sea: add support for V8 bytecode-only caching - #48191

sea: add support for V8 bytecode-only caching#48191nodejs-github-bot merged 27 commits intonodejs:mainnodejs/node:mainfrom RaisinTen:sea-V8-code-cacheRaisinTen/node:sea-V8-code-cacheCopy head branch name to clipboard

Conversation

RaisinTen commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RaisinTen commented Jun 2, 2023

Uh oh!

Uh oh!

kvakil left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaisinTen commented Jul 21, 2023

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jul 26, 2023

Uh oh!

nodejs-github-bot commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sea: add support for V8 bytecode-only caching#48191
nodejs-github-bot merged 27 commits into
nodejs:mainfrom
RaisinTen:sea-V8-code-cache

RaisinTen commented May 26, 2023 •
edited
Loading

kvakil left a comment •
edited
Loading

joyeecheung commented Jun 10, 2023 •
edited
Loading