FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: next iteration by jasnell · Pull Request #48244 · nodejs/node · GitHub

/ node Public

quic: next iteration - #48244

Closed
jasnell wants to merge 8 commits into
nodejs:mainfrom
jasnell:quic-part-7
ConversationCommits (8)ChecksFiles changed
Closed

quic: next iteration#48244
jasnell wants to merge 8 commits into
nodejs:mainfrom
jasnell:quic-part-7

Conversation

jasnell commented May 29, 2023

Copy link
Copy Markdown
Member

Adds the basic implementation of the quic stream. Still more to come.

jasnell requested review from Qard, anonrig and tniessen May 29, 2023 18:21
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 29, 2023
anonrig reviewed May 29, 2023
View reviewed changes
Comment thread src/dataqueue/queue.cc Outdated
Comment thread src/dataqueue/queue.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
achingbrain mentioned this pull request May 30, 2023
Open
Qard reviewed Jun 1, 2023
View reviewed changes
Comment thread src/quic/streams.cc Outdated
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3. dont-land-on-v16.x labels Jun 3, 2023

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52117/

This was referenced Jun 6, 2023
Open
Open
Open

nodejs-github-bot commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52192/

This was referenced Jun 11, 2023
Open
Open
Open
Open
Open
This was referenced Sep 19, 2023
Open
Open
achingbrain mentioned this pull request Oct 1, 2023
Closed

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 9, 2023

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Dec 10, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56214/ 💚

jasnell added a commit that referenced this pull request Dec 11, 2023
quic: further implementation details
fc102f2 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

jasnell commented Dec 11, 2023

Copy link
Copy Markdown
Member Author

Landed in fc102f2

jasnell closed this Dec 11, 2023
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
quic: further implementation details
3fb7fc9 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
robertsLando mentioned this pull request Aug 8, 2024
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
anonrig anonrig approved these changes
tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL