| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/48249 ✔ Done loading data for nodejs/node/pull/48249 ----------------------------------- PR info ------------------------------------ Title esm: handle `globalPreload` hook returning a nullish value (#48249) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:globalPreload-nullish -> nodejs:main Labels esm, author ready, needs-ci Commits 1 - esm: handle `globalPreload` hook returning a nullish value Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48249 Fixes: https://github.com/nodejs/node/issues/48240 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48249 Fixes: https://github.com/nodejs/node/issues/48240 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 May 2023 09:59:28 GMT ✔ Approvals: 2 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/48249#pullrequestreview-1451284058 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/48249#pullrequestreview-1451367545 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-31T11:02:18Z: https://ci.nodejs.org/job/node-test-pull-request/52016/ - Querying data for job/node-test-pull-request/52016/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48249 From https://github.com/nodejs/node * branch refs/pull/48249/merge -> FETCH_HEAD ✔ Fetched commits as d57dd708e249..4910e199ae84 -------------------------------------------------------------------------------- Auto-merging lib/internal/modules/esm/hooks.js Auto-merging test/es-module/test-esm-loader-hooks.mjs CONFLICT (content): Merge conflict in test/es-module/test-esm-loader-hooks.mjs error: could not apply 4910e199ae... esm: handle `globalPreload` hook returning a nullish value hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/5142967649 |
Sorry, something went wrong.
PR-URL: nodejs#48249 Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#48249 Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#48249 Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#48249 Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs/node#48249 Backport-PR-URL: nodejs/node#50669 Fixes: nodejs/node#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs/node#48249 Backport-PR-URL: nodejs/node#50669 Fixes: nodejs/node#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
| Back | FazBrowse Home | New Git URL |
Fixes: #48240