test: fix test-net-autoselectfamily for kernel without IPv6 support - #48265
Conversation
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| assert.strictEqual(error.code, 'ECONNREFUSED'); | ||
| assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`); | ||
| } else if (error.code === 'EAFNOSUPPORT') { | ||
| assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`); |
There was a problem hiding this comment.
That undefined:undefined is a bit weird.
Sorry, something went wrong.
There was a problem hiding this comment.
Well, it makes sense for systems without IPv6 support to not know how to represent invalid/unknown source [address]:port. 😄
It is possible to adjust all exceptionWithHostPort(..., additional) calls so they will try to provide more descriptive error in this specific case, but not worth it imho.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/48265 ✔ Done loading data for nodejs/node/pull/48265 ----------------------------------- PR info ------------------------------------ Title test: fix `test-net-autoselectfamily` for kernel without IPv6 support (#48265) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:net-test-asf-cmd-option-noipv6 -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix `test-net-autoselectfamily` for kernel without IPv6 support Committers 1 - LiviaMedeiros PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 May 2023 16:13:48 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48265#pullrequestreview-1456022547 ✘ This PR needs to wait 82 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-01T12:55:51Z: https://ci.nodejs.org/job/node-test-pull-request/52050/ - Querying data for job/node-test-pull-request/52050/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5167492972 |
Sorry, something went wrong.
PR-URL: #48265 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
hi @LiviaMedeiros this commit is not landing cleanly in v18.x-staging and will need manual backporting. |
Sorry, something went wrong.
|
Sure; I'll open backport PR if https://github.com/nodejs/node/blame/v18.18.0-proposal/test/parallel/test-net-autoselectfamily-commandline-option.js will become affected by this problem and this PR still won't be landable. Right now affected test seem to not rely in EADDRNOTAVAIL in v18.x branch (and there's a chance that the PR that added this test was semver-major) so this PR can be skipped. |
Sorry, something went wrong.
If CONFIG_IPV6 is disabled, the observed error on some platforms is EAFNOSUPPORT instead of EADDRNOTAVAIL.