benchmark: refactor crypto oneshot - #48267
Merged
nodejs-github-bot merged 2 commits intoJun 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/crypto, also see nodejs/performance#72 (comment) |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Jun 1, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 2, 2023
panva
force-pushed
the
bench-crypto-oneshots
branch
from
73bcad2 to
ac260a8
Compare
June 5, 2023 07:49
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/performance |
Sorry, something went wrong.
anonrig
reviewed
Jun 5, 2023
Comment thread
benchmark/crypto/oneshot-sign.js
Outdated
Comment thread
benchmark/crypto/oneshot-sign.js
Outdated
Comment thread
benchmark/crypto/oneshot-verify.js
Outdated
anonrig
approved these changes
Jun 5, 2023
20 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 29, 2023
PR-URL: #48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the result of my shallow look at nodejs/performance#72