FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: reduce the number of URL initializations by anonrig · Pull Request #48272 · nodejs/node · GitHub

/ node Public

module: reduce the number of URL initializations - #48272

Closed
anonrig wants to merge 2 commits into
nodejs:mainfrom
anonrig:esm-loader-url
ConversationCommits (2)ChecksFiles changed
Closed

module: reduce the number of URL initializations#48272
anonrig wants to merge 2 commits into
nodejs:mainfrom
anonrig:esm-loader-url

Conversation

anonrig commented May 31, 2023

Copy link
Copy Markdown
Member

This reduces the number of URL creations. There are still a lot of unnecessary URL initializations, but I believe we are moving in the right direction.

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 31, 2023
GeoffreyBooth approved these changes May 31, 2023
View reviewed changes

GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for doing this!

Comment thread lib/internal/modules/esm/get_format.js Outdated
Comment thread lib/internal/modules/esm/get_format.js Outdated
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52037/

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52040/

anonrig mentioned this pull request Jun 1, 2023
Closed

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52053/

anonrig added a commit that referenced this pull request Jun 3, 2023
module: reduce the number of URL initializations
54e0cb5 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

anonrig commented Jun 3, 2023

Copy link
Copy Markdown
Member Author

Landed in 54e0cb5

anonrig closed this Jun 3, 2023
targos pushed a commit that referenced this pull request Jun 4, 2023
module: reduce the number of URL initializations
6d6bf3e 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
module: reduce the number of URL initializations
e816cd2 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
module: reduce the number of URL initializations
5d75ec4 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Aug 13, 2023
esm: align sync and async load implementations
76f1380 
Refs: nodejs#48272
aduh95 mentioned this pull request Aug 13, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
module: reduce the number of URL initializations
8819352 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
module: reduce the number of URL initializations
740c136 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 20, 2023
esm: align sync and async load implementations
2557932 
Refs: #48272
PR-URL: #49152
Refs: #47999
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
esm: align sync and async load implementations
a6cfea3 
Refs: #48272
PR-URL: #49152
Refs: #47999
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
lpinca lpinca approved these changes
KhafraDev KhafraDev approved these changes
+1 more reviewer
Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL