FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: add crypto.create*Key by panva · Pull Request #48284 · nodejs/node · GitHub

/ node Public

benchmark: add crypto.create*Key - #48284

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:crypto-bench-createKey
Jun 5, 2023
Merged

benchmark: add crypto.create*Key#48284
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:crypto-bench-createKey

Conversation

panva commented Jun 1, 2023

Copy link
Copy Markdown
Member

Adds crypto.createPrivateKey and crypto.createPublicKey benchmarks for pem, der, and jwk inputs using rsa, ec, and ed25519 key fixtures.

panva added crypto Issues and PRs related to the crypto subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 1, 2023

panva commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/crypto

Comment thread benchmark/crypto/create-keyobject.js Outdated

tniessen commented Jun 2, 2023

Copy link
Copy Markdown
Member

cc @nodejs/performance

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good with @tniessen's suggestion

Comment thread benchmark/crypto/create-keyobject.js Outdated
panva force-pushed the crypto-bench-createKey branch from a3647aa to 2b9eaba Compare June 5, 2023 07:49
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 5, 2023
panva requested review from anonrig and tniessen June 5, 2023 09:58
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023
nodejs-github-bot merged commit 6327d45 into nodejs:main Jun 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6327d45

panva deleted the crypto-bench-createKey branch June 5, 2023 16:55
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
PR-URL: #48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno mentioned this pull request Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL