FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: add support for inherited custom inspection methods by aduh95 · Pull Request #48306 · nodejs/node · GitHub

/ node Public

lib: add support for inherited custom inspection methods - #48306

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:error-serdes-inherit-custom-inspect
Jun 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

lib: add support for inherited custom inspection methods#48306
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:error-serdes-inherit-custom-inspect

Conversation

aduh95 commented Jun 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #48207

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 2, 2023
aduh95 mentioned this pull request Jun 2, 2023
Closed
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2023

nodejs-github-bot commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52072/

This was referenced Jun 4, 2023
Open
Open
Open

nodejs-github-bot commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52187/

nodejs-github-bot commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52199/

github-actions Bot mentioned this pull request Jun 11, 2023
Open
25 tasks
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2023
nodejs-github-bot merged commit 2c6698b into nodejs:main Jun 11, 2023

nodejs-github-bot commented Jun 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2c6698b

aduh95 deleted the error-serdes-inherit-custom-inspect branch June 11, 2023 08:12
This was referenced Jun 12, 2023
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
lib: add support for inherited custom inspection methods
0162a0f 
PR-URL: #48306
Fixes: #48207
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
lib: add support for inherited custom inspection methods
117c65d 
PR-URL: nodejs#48306
Fixes: nodejs#48207
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
lib: add support for inherited custom inspection methods
9c2e20d 
PR-URL: nodejs#48306
Fixes: nodejs#48207
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
lib: add support for inherited custom inspection methods
f10ebb0 
PR-URL: #48306
Fixes: #48207
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno mentioned this pull request Aug 29, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
lib: add support for inherited custom inspection methods
5260f53 
PR-URL: #48306
Fixes: #48207
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node 20: errors with util.inspect.custom raised in loader thread not serialized/deserialized correctly

3 participants

Back | FazBrowse Home | New Git URL