Revert "tools: open issue when update workflow fails" - #48312
Merged
nodejs-github-bot merged 1 commit intoJun 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit c488558.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
richardlau
approved these changes
Jun 3, 2023
Mesteery
approved these changes
Jun 3, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Why did the step run at all? #48308 was opened by a manual run, wasn't it? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yes it was triggered by @anonrig, there is something wrong in the action, reverting this until we figure it out before it starts opening like 20 issues this sunday |
Sorry, something went wrong.
aduh95
approved these changes
Jun 3, 2023
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c488558.
the action creates an issue that dep update failed: #48309 but actually worked #48308, while other jobs failed