FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ada to 2.5.1 by nodejs-github-bot · Pull Request #48319 · nodejs/node · GitHub

/ node Public

deps: update ada to 2.5.1 - #48319

Closed
nodejs-github-bot wants to merge 3 commits into
mainfrom
actions/tools-update-ada
ConversationCommits (3)ChecksFiles changed
Closed

deps: update ada to 2.5.1#48319
nodejs-github-bot wants to merge 3 commits into
mainfrom
actions/tools-update-ada

Conversation

nodejs-github-bot commented Jun 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.5.1.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jun 3, 2023

nodejs-github-bot commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 3, 2023
anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 3, 2023
anonrig requested a review from lpinca June 3, 2023 16:52

anonrig commented Jun 3, 2023

Copy link
Copy Markdown
Member

I added changes to this pull request, since these changes are required for the web platform tests to update.

This PR fixes: #48157

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 3, 2023

github-actions Bot commented Jun 3, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2023

nodejs-github-bot commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52071/

anonrig commented Jun 3, 2023

Copy link
Copy Markdown
Member

PS: This pull request includes a bug fix (for URLs that contain 0 port number), as well as a fix for the spec compliance on URL getter.

aduh95 commented Jun 3, 2023

Copy link
Copy Markdown
Contributor

node/doc/contributing/collaborator-guide.md

Lines 543 to 544 in 260092e

All commits should be self-contained, meaning every commit should pass all
tests. This makes it much easier when bisecting to find a breaking change.

I guess we would need to squash 019723c and c3a1c64 upon landing, right? Or maybe land c3a1c64 first and update the status when upgrading ada.

anonrig commented Jun 3, 2023

Copy link
Copy Markdown
Member

@aduh95 We don't need to squash since all commits build correctly. In the second commit, I added url origin getter to url.json wpt file, and in 3rd I removed it. But even with wpt files update commit, everything works correctly.

nodejs-github-bot commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52076/

github-actions Bot mentioned this pull request Jun 4, 2023
Open
30 tasks

nodejs-github-bot commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52078/

nodejs-github-bot commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52089/

github-actions Bot mentioned this pull request Jun 5, 2023
Open
30 tasks
anonrig force-pushed the actions/tools-update-ada branch from 2fb0e11 to 99bdf92 Compare June 5, 2023 13:15
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52102/

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52116/

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52118/

github-actions Bot mentioned this pull request Jun 6, 2023
Open
20 tasks
anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 23c7f65...f2670a6

nodejs-github-bot added a commit that referenced this pull request Jun 7, 2023
deps: update ada to 2.5.1
11bd9f9 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
test: update url web-platform tests
e6e0110 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
url: conform to origin getter spec changes
f2670a6 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos deleted the actions/tools-update-ada branch June 7, 2023 11:47
This was referenced Jun 9, 2023
Open
Open
hemanth mentioned this pull request Jun 11, 2023
Closed
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
deps: update ada to 2.5.1
8cd56c1 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
test: update url web-platform tests
764119b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
url: conform to origin getter spec changes
fafe651 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
deps: update ada to 2.5.1
262f965 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: update url web-platform tests
0bdbf9d 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
url: conform to origin getter spec changes
882b9dd 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
deps: update ada to 2.5.1
d467e03 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: update url web-platform tests
5ba5335 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
url: conform to origin getter spec changes
34ff09a 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
deps: update ada to 2.5.1
a2964a4 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
test: update url web-platform tests
cb92c4b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
url: conform to origin getter spec changes
d428e6b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno mentioned this pull request Aug 29, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
url: conform to origin getter spec changes
f59c963 
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL