FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: run license-builder by github-actions[bot] · Pull Request #48336 · nodejs/node · GitHub

/ node Public

doc: run license-builder - #48336

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/license-builder
Jun 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: run license-builder#48336
nodejs-github-bot merged 1 commit into
mainfrom
actions/license-builder

Conversation

github-actions Bot commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

github-actions Bot added the meta Issues and PRs related to the general management of the project. label Jun 5, 2023

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

aduh95 commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Pinging @fasenderos since they are the one who drove the zlib upgrade changes, and the diff looks a bit weird.

fasenderos commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

@aduh95 I'll take a look

fasenderos commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

The changes of this PR reflect the Chromium's copy of zlib that we use (we don't use the official zlib library):
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/zlib.h#2

targos commented Jun 6, 2023

Copy link
Copy Markdown
Member

More specifically, the license header was changed in https://chromium.googlesource.com/chromium/src/+/f103edb8dc89fd780cd374ca34707617f49d0303%5E%21/#F10

mhdawson approved these changes Jun 6, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM defintely hard to line up with what is obvious from the contents under deps but seem to be the right value from the patch @targos linked to.

RafaelGSS approved these changes Jun 6, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for checking it @fasenderos @targos. LGTM.

Mesteery added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 6, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023
nodejs-github-bot merged commit f100732 into main Jun 7, 2023

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in f100732

nodejs-github-bot deleted the actions/license-builder branch June 7, 2023 00:29
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
doc: run license-builder
e10a4cd 
PR-URL: #48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: run license-builder
bc38f69 
PR-URL: nodejs#48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: run license-builder
aed534e 
PR-URL: nodejs#48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
doc: run license-builder
0651358 
PR-URL: #48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno mentioned this pull request Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes
+2 more reviewers
mhdawson mhdawson approved these changes
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL