module: reduce url invocations in esm/load.js - #48337
Merged
nodejs-github-bot merged 2 commits intoJun 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
force-pushed
the
improve-esm-loadjs
branch
from
cadc77b to
724ee2e
Compare
June 5, 2023 01:13
anonrig
force-pushed
the
improve-esm-loadjs
branch
from
724ee2e to
bd035a6
Compare
June 5, 2023 01:31
Qard
approved these changes
Jun 5, 2023
aduh95
approved these changes
Jun 5, 2023
Comment thread
lib/internal/modules/esm/load.js
Comment thread
lib/internal/modules/esm/load.js
Outdated
Comment thread
lib/internal/modules/esm/load.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Jun 5, 2023
Comment thread
lib/internal/modules/esm/load.js
lpinca
approved these changes
Jun 6, 2023
JakobJingleheimer
approved these changes
Jun 6, 2023
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think we had talked about something similar previously, where I suggested the load hook be passed a URL instance (which we already have internally), but for some reason that I don't recall that was not good.
I think whatever that reason (something about mutability?) was, it doesn't apply here because this is internal.
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48337 Refs: nodejs/performance#92 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48337 Refs: nodejs/performance#92 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48337 Refs: nodejs/performance#92 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 29, 2023
PR-URL: #48337 Refs: nodejs/performance#92 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 19, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 19, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 20, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 20, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 20, 2023
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Sep 20, 2023
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464 ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464 ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces unnecessary new URL call, and removes unnecessary invokes to url.protocol
Ref: nodejs/performance#92