48198 node api external strings - #48339
Closed
gabrielschulhof wants to merge 31 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
gabrielschulhof
commented
Jun 5, 2023
Comment thread
src/js_native_api_v8.cc
Outdated
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Check with Electron if this is needed for strings.
Sorry, something went wrong.
gabrielschulhof
commented
Jun 5, 2023
Comment thread
src/js_native_api_v8.cc
Outdated
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Is it OK if lengh is NAPI_AUTO_LENGTH?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Chose to assume that it is not, and used C++ string view to compute length.
Sorry, something went wrong.
daeyeon
reviewed
Jun 5, 2023
Comment thread
src/js_native_api_v8.cc
Outdated
Comment thread
src/js_native_api_v8.cc
Outdated
Comment thread
src/js_native_api_v8.cc
Outdated
Comment thread
src/js_native_api_v8.cc
Outdated
gabrielschulhof
force-pushed
the
48198-node-api-external-strings
branch
from
cf6e959 to
20ab0fb
Compare
June 7, 2023 15:25
gabrielschulhof
commented
Jun 8, 2023
Comment thread
test/js-native-api/test_string/test_string.c
Outdated
Comment thread
test/js-native-api/test_string/test_string.c
Outdated
Comment thread
test/js-native-api/test_string/test_string.c
Outdated
daeyeon
reviewed
Jun 8, 2023
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
gabrielschulhof
commented
Jun 11, 2023
daeyeon
reviewed
Jun 12, 2023
Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
approved these changes
Jun 12, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 13, 2023
gabrielschulhof
added a commit
that referenced
this pull request
Jun 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
This was referenced Jun 15, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: nodejs#48339 Fixes: nodejs#48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: nodejs#48339 Fixes: nodejs#48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 8, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Introduce APIs that allow for the creation of JavaScript strings without copying the underlying native string into the engine. The APIs fall back to regular string creation if the engine's external string APIs are unavailable. In this case, an optional boolean out-parameter indicates that the string was copied, and the optional finalizer is called if given. PR-URL: #48339 Fixes: #48198 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.