test: add missing <algorithm> include for std::find - #48380
Merged
nodejs-github-bot merged 1 commit intoJun 9, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, this is identical to #48330 - I was playing with some github tooling to update local forks and messed it up (and it deleted the fork). Apologies for the hassle folks. |
Sorry, something went wrong.
LiviaMedeiros
approved these changes
Jun 7, 2023
Comment thread
test/embedding/embedtest.cc
Outdated
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org>
lpinca
approved these changes
Jun 7, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
KhafraDev
approved these changes
Jun 7, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: #48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: nodejs#48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: nodejs#48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 29, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: #48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 1, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: #48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.
Signed-off-by: Sam James sam@gentoo.org