FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add preveen-stack to triagers by preveen-stack · Pull Request #48387 · nodejs/node · GitHub

/ node Public

doc: add preveen-stack to triagers - #48387

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
preveen-stack:add-preveen-stack-to-triagers
Jun 15, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: add preveen-stack to triagers#48387
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
preveen-stack:add-preveen-stack-to-triagers

Conversation

preveen-stack commented Jun 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I have been contributing nodejs ecosystem over the last few years

I would like to get more involved and am looking forward to becoming a contributor

I have read through nodejs code of conduct and promise to adhere to the same 🙏🏽

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 8, 2023

MoLow commented Jun 8, 2023

Copy link
Copy Markdown
Member

Hey,
I only see this PR and another one you opened:
https://github.com/search?q=org%3Anodejs+author%3Apreveen-stack+&type=pullrequests
the links you added seem to be incorrect

preveen-stack marked this pull request as ready for review June 8, 2023 06:18

preveen-stack commented Jun 8, 2023

Copy link
Copy Markdown
Contributor Author

@MoLow Thanks for reviewing. I have updated the links. pls check

aduh95 commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

Any chance you could reword the commit message to comply with our guidelines?

node/doc/contributing/pull-requests.md

Lines 162 to 179 in 260092e

1. The first line should:
* contain a short description of the change (preferably 50 characters or
less, and no more than 72 characters)
* be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.
Examples:
* `net: add localAddress and localPort to Socket`
* `src: fix typos in async_wrap.h`
2. Keep the second line blank.
3. Wrap all other lines at 72 columns (except for long URLs).

It should look like doc: add preveen-stack to triagers. Let me know if you need help with that.

preveen-stack changed the title propose preveen-stack as a triager doc: add preveen-stack to triagers Jun 10, 2023

preveen-stack commented Jun 10, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @aduh95. Changed the commit message as per requirement.

aduh95 commented Jun 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@preveen-stack no you changed the PR title :) to change the commit title, you need to use the CLI. Let me know if you need help, I can do it for you if you prefer.

preveen-stack commented Jun 10, 2023

Copy link
Copy Markdown
Contributor Author

@aduh95 if you don't mind, please go ahead and change the commit message. Thanks

aduh95 force-pushed the add-preveen-stack-to-triagers branch from 0c0ca36 to 7def7df Compare June 10, 2023 16:41

aduh95 commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Seven days have passed and no objections have been made, this self-nomination has officially passed. Congrats and welcome to the triagers!

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jun 15, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2023
nodejs-github-bot merged commit c760ff2 into nodejs:main Jun 15, 2023

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in c760ff2

gireeshpunathil commented Jun 15, 2023

Copy link
Copy Markdown
Member

Congratulations @preveen-stack! I just sent an invitation to you to join the triage team!

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
doc: add preveen-stack to triagers
641a2e9 
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: add preveen-stack to triagers
e4b1580 
PR-URL: nodejs#48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: add preveen-stack to triagers
b1f5d7b 
PR-URL: nodejs#48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
doc: add preveen-stack to triagers
6f5f4aa 
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
ruyadorno mentioned this pull request Sep 8, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
doc: add preveen-stack to triagers
7575d8b 
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
preveen-stack deleted the add-preveen-stack-to-triagers branch November 13, 2024 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ayase-252 Ayase-252 approved these changes
gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL