FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: create weakRef only if any signals provided by atlowChemi · Pull Request #48448 · nodejs/node · GitHub

/ node Public

lib: create weakRef only if any signals provided - #48448

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
atlowChemi:lib--create-weakRef-only-if-any-signals-provided
Jun 15, 2023
ConversationCommits (1)ChecksFiles changed
Merged

lib: create weakRef only if any signals provided#48448
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
atlowChemi:lib--create-weakRef-only-if-any-signals-provided

Conversation

atlowChemi commented Jun 13, 2023

Copy link
Copy Markdown
Member

Fixes: #48419

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 13, 2023
atlowChemi requested review from Linkgoron and MoLow June 13, 2023 12:44
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from b74da91 to f70772d Compare June 13, 2023 12:48
atlowChemi requested a review from Linkgoron June 13, 2023 12:48
atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52238/

aduh95 reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from f70772d to 26d8fbe Compare June 13, 2023 13:48
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from 26d8fbe to 6cb4ad9 Compare June 13, 2023 14:18
atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52240/

atlowChemi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 13, 2023

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52243/

github-actions Bot mentioned this pull request Jun 14, 2023
Open
20 tasks
atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
github-actions Bot mentioned this pull request Jun 15, 2023
Open
22 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2023
nodejs-github-bot merged commit f3ee4e2 into nodejs:main Jun 15, 2023

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in f3ee4e2

atlowChemi deleted the lib--create-weakRef-only-if-any-signals-provided branch June 15, 2023 12:56
github-actions Bot mentioned this pull request Jun 21, 2023
Open
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
lib: create weakRef only if any signals provided
8c2c02d 
PR-URL: #48448
Fixes: #48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
atlowChemi mentioned this pull request Jul 16, 2023
Closed
atlowChemi added a commit to atlowChemi/node that referenced this pull request Jul 17, 2023
lib: create weakRef only if any signals provided
a30ecab 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
lib: create weakRef only if any signals provided
156292d 
PR-URL: #48448
Backport-PR-URL: #48800
Fixes: #48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jul 18, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
lib: create weakRef only if any signals provided
4198d5c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
lib: create weakRef only if any signals provided
30b380c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
MoLow MoLow approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AbortSignal.any() not destroyed when goes out of scope

7 participants

Back | FazBrowse Home | New Git URL