FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: refine when file is undefined in test events by MoLow · Pull Request #48451 · nodejs/node · GitHub

/ node Public

doc: refine when file is undefined in test events - #48451

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:adjust-file-docs
Jun 14, 2023
Merged

doc: refine when file is undefined in test events#48451
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:adjust-file-docs

Conversation

MoLow commented Jun 13, 2023

Copy link
Copy Markdown
Member

Follow-up for #48428 (comment)

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jun 13, 2023
MoLow requested a review from benjamingr June 13, 2023 18:39
Comment thread doc/api/test.md Outdated
MoLow force-pushed the adjust-file-docs branch from 9c15d15 to d4fd3a1 Compare June 14, 2023 08:10
benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 14, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
nodejs-github-bot merged commit 363eca1 into nodejs:main Jun 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 363eca1

MoLow deleted the adjust-file-docs branch June 14, 2023 15:12
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno mentioned this pull request Sep 8, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL