fs: remove unneeded return statement - #48526
Merged
nodejs-github-bot merged 1 commit intoJun 26, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
force-pushed
the
remove/return-statement
branch
from
4e3ba1c to
d7014d6
Compare
June 22, 2023 19:57
The `writable._write()` implementation does not need to return anything, only call the callback.
lpinca
force-pushed
the
remove/return-statement
branch
from
d7014d6 to
6fb96bb
Compare
June 22, 2023 19:59
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
30 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
kvakil
approved these changes
Jun 23, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
25 tasks
debadree25
approved these changes
Jun 24, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
25 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
21 tasks
deokjinkim
approved these changes
Jun 26, 2023
24 tasks
This was referenced Jun 28, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: nodejs#48526 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: nodejs#48526 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writable._write() implementation does not need to return anything, only call the callback.