FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http, https, http2: Server add `Symbol.asyncDispose` by atlowChemi · Pull Request #48548 · nodejs/node · GitHub

/ node Public

http, https, http2: Server add Symbol.asyncDispose - #48548

Closed
atlowChemi wants to merge 6 commits into
nodejs:mainfrom
atlowChemi:http-server-async-dispose
ConversationCommits (6)ChecksFiles changed
Closed

http, https, http2: Server add Symbol.asyncDispose#48548
atlowChemi wants to merge 6 commits into
nodejs:mainfrom
atlowChemi:http-server-async-dispose

Conversation

atlowChemi commented Jun 25, 2023

Copy link
Copy Markdown
Member

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jun 25, 2023
atlowChemi requested review from MoLow and benjamingr June 25, 2023 17:54
atlowChemi force-pushed the http-server-async-dispose branch from 7fff95c to 6f92f87 Compare June 25, 2023 18:00
benjamingr reviewed Jun 25, 2023
View reviewed changes
Comment thread doc/api/http.md Outdated
benjamingr reviewed Jun 25, 2023
View reviewed changes
Comment thread lib/_http_server.js Outdated
benjamingr reviewed Jun 25, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good left some comments

atlowChemi force-pushed the http-server-async-dispose branch from 6f92f87 to d293a6a Compare June 25, 2023 18:03
atlowChemi force-pushed the http-server-async-dispose branch from d293a6a to 81f630f Compare June 25, 2023 18:16
atlowChemi changed the title http: Server add Symbol.asyncDispose http, http2: Server add Symbol.asyncDispose Jun 25, 2023
atlowChemi added the http2 Issues or PRs related to the http2 subsystem. label Jun 25, 2023
atlowChemi requested a review from benjamingr June 25, 2023 20:30
atlowChemi force-pushed the http-server-async-dispose branch from bd52b5a to 7577fd8 Compare June 25, 2023 20:30
atlowChemi added the https Issues or PRs related to the https subsystem. label Jun 25, 2023
atlowChemi changed the title http, http2: Server add Symbol.asyncDispose http, https, http2: Server add Symbol.asyncDispose Jun 25, 2023
atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2023

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52474/

github-actions Bot mentioned this pull request Jun 26, 2023
Open
21 tasks
atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52477/

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52479/

ShogunPanda approved these changes Jun 26, 2023
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

MoLow pushed a commit that referenced this pull request Jun 29, 2023
http: server add async dispose
909b43f 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MoLow pushed a commit that referenced this pull request Jun 29, 2023
http2: server add asyncDispose
b7bfb17 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MoLow pushed a commit that referenced this pull request Jun 29, 2023
https: server add asyncDispose
e8810b9 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
atlowChemi deleted the http-server-async-dispose branch June 29, 2023 08:55
This was referenced Jun 30, 2023
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
http: server add async dispose
94ebb02 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
http2: server add asyncDispose
5378ad8 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
https: server add asyncDispose
97a58c5 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
github-actions Bot mentioned this pull request Jul 4, 2023
Open
22 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
http: server add async dispose
377a9f4 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
http2: server add asyncDispose
1aad923 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
https: server add asyncDispose
a9efe2e 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
http: server add async dispose
9df83ae 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
http2: server add asyncDispose
0af65d0 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
https: server add asyncDispose
6fcb5d2 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
http: server add async dispose
3edeeac 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
http2: server add asyncDispose
3ecc607 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
https: server add asyncDispose
9e9b8a3 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno mentioned this pull request Sep 11, 2023
Merged

ruyadorno commented Sep 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR is not landing cleanly on v18.x-staging since #48383 had to be removed. It's going to be blocked pending the backport of that PR.

ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
http: server add async dispose
fcd0424 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
http2: server add asyncDispose
7a00bda 
PR-URL: #48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL