test: add Symbol.dispose support to mocktimers - #48549
Merged
nodejs-github-bot merged 2 commits intoJun 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
benjamingr
force-pushed
the
add-dispose-mocktimers
branch
from
ecb547c to
9ff2888
Compare
June 25, 2023 18:12
aduh95
reviewed
Jun 25, 2023
Comment thread
lib/internal/test_runner/mock/mock_timers.js
cjihrig
approved these changes
Jun 25, 2023
MoLow
approved these changes
Jun 25, 2023
aduh95
approved these changes
Jun 26, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ErickWendel
approved these changes
Jun 26, 2023
ErickWendel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
benjamingr
commented
Jun 26, 2023
Comment thread
doc/api/test.md
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 28, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48549 ✔ Done loading data for nodejs/node/pull/48549 ----------------------------------- PR info ------------------------------------ Title test: add Symbol.dispose support to mocktimers (#48549) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-dispose-mocktimers -> nodejs:main Labels needs-ci, commit-queue-squash, test_runner Commits 2 - test: add Symbol.dispose support to mock timers - Update doc/api/test.md Committers 2 - Benjamin Gruenbaum - GitHub PR-URL: https://github.com/nodejs/node/pull/48549 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48549 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update doc/api/test.md ℹ This PR was created on Sun, 25 Jun 2023 18:10:38 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497181144 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497192386 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497609652 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/48549#pullrequestreview-1498055208 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-29T06:44:07Z: https://ci.nodejs.org/job/node-test-pull-request/52554/ - Querying data for job/node-test-pull-request/52554/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5409591686 |
Sorry, something went wrong.
MoLow
approved these changes
Jun 29, 2023
This was referenced Jun 30, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Merged
This was referenced Jul 4, 2023
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Copy link
Copy Markdown
Member
|
This is blocked from landing on v18.x-staging pending backport of #47775 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Symbol.dispose in mock timers. Letting users of TS/Babel (and everyone else as soon as v8 ships) use using with the mock timers.
cc @ErickWendel @nodejs/test_runner