src: deduplicate X509 getter implementations - #48563
Merged
nodejs-github-bot merged 1 commit intoJul 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters.
tniessen
force-pushed
the
src-crypto-x509-dedup-getters
branch
from
2dbacb7 to
a443b5a
Compare
June 26, 2023 14:07
juanarbol
approved these changes
Jun 27, 2023
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
36 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 29, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jul 1, 2023
mildsunrise
approved these changes
Jul 3, 2023
This was referenced Jul 4, 2023
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: #48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: nodejs#48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: nodejs#48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 11, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: #48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: #48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2023
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: #48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters.
As usual, a lot of the diff is just to appease the format-cpp job.