test: fs.link() on same device - #4859
Closed
drewfish wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
If `NODE_TEST_DIR` is set to a device different than the location of the test files (where this repo is checked out), then the parallel/test-fs-link.js test will fail with `EXDEV: cross-device link not permitted`. The code works fine (and is in fact throwing an error as desired) but the test fails. This commit first copies the "source" file to the same directory as the "destination" (where the hardlink will be created).
Copy link
Copy Markdown
Contributor
Author
|
BTW this PR is onto the v4.x branch since that's primarily what I'm trying to build/test, but I can submit a separate PR for master if desired. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Typically PRs should always be targeting master. Once they land there, a collaborator will cherry-pick necessary commits back to versioned branches. If the problem doesn't exist on master, then it's usually (if feasible) just a matter of finding the existing commit in master to backport. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
OK thanks, I'll submit a PR on master (and then we can figure out what to do with this PR). |
Sorry, something went wrong.
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Oct 17, 2022
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If NODE_TEST_DIR is set to a device different than the location of the test
files (where this repo is checked out), then the parallel/test-fs-link.js
test will fail with EXDEV: cross-device link not permitted. The code works
fine (and is in fact throwing an error as desired) but the test fails.
This commit first copies the "source" file to the same directory as the
"destination" (where the hardlink will be created).