[v16.x] test: mark flaky parallel tests - #48650
Closed
StefanStojanovic wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR-URL: nodejs#48334 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow
approved these changes
Jul 4, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
Sorry, something went wrong.
richardlau
approved these changes
Jul 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jul 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Jul 6, 2023
Copy link
Copy Markdown
Contributor
Author
|
Is there something else I can do to help move this forward? |
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Jul 11, 2023
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Backport-PR-URL: #48650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #48345 (comment), the v16.x-staging branch is missing flaky tests, which makes the daily job fail constantly. This PR marks the flaky tests, for the v16 branch, in the same way as #48601 does for the v18 branch.