stream: fix deadlock when pipeing to full sink - #48691
Merged
nodejs-github-bot merged 1 commit intoJul 12, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ronag
force-pushed
the
fix-pipe-deadlock
branch
2 times, most recently
from
07ade06 to
f11c61f
Compare
July 7, 2023 12:12
ronag
commented
Jul 7, 2023
Comment thread
lib/internal/streams/readable.js
Outdated
benjamingr
approved these changes
Jul 7, 2023
benjamingr
approved these changes
Jul 7, 2023
lpinca
approved these changes
Jul 7, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Jul 8, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ronag could you fix the commit message? |
Sorry, something went wrong.
This comment was marked as resolved.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48691 ✔ Done loading data for nodejs/node/pull/48691 ----------------------------------- PR info ------------------------------------ Title stream: fix deadlock when pipeing to full sink (#48691) Author Robert Nagy (@ronag) Branch ronag:fix-pipe-deadlock -> nodejs:main Labels stream, needs-ci Commits 1 - stream: fix deadlock when pipeing to full sink Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/48691 Refs: https://github.com/nodejs/node/issues/48666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48691 Refs: https://github.com/nodejs/node/issues/48666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: fix deadlock when pipeing to full sink ℹ This PR was created on Fri, 07 Jul 2023 12:08:43 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48691#pullrequestreview-1518738423 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48691#pullrequestreview-1518877825 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48691#pullrequestreview-1520765659 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-07-10T08:08:41Z: https://ci.nodejs.org/job/node-test-pull-request/52681/ - Querying data for job/node-test-pull-request/52681/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5512507137 |
Sorry, something went wrong.
mcollina
approved these changes
Jul 12, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Copy link
Copy Markdown
Contributor
|
Any plans to backport? Technically, the exact same patch should apply cleanly. |
Sorry, something went wrong.
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Contributor
|
Can we at least backport this to v18? |
Sorry, something went wrong.
kanongil
pushed a commit
to kanongil/node-1
that referenced
this pull request
Aug 25, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Backport-PR-URL: nodejs#49323 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 8, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Backport-PR-URL: #49323 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Backport-PR-URL: #49323 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume.
Refs: #48666