FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix callback_queue.h missing header by CGQAQ · Pull Request #48733 · nodejs/node · GitHub

/ node Public

src: fix callback_queue.h missing header - #48733

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CGQAQ:src-fix-callback_queue-missing-header
Aug 10, 2023
Merged

src: fix callback_queue.h missing header#48733
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CGQAQ:src-fix-callback_queue-missing-header

Conversation

CGQAQ commented Jul 11, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

std::unique_ptr is in the memory header, this PR adds the header inclusion

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023

CGQAQ commented Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

I don't think the failing test is related to this PR

aduh95 requested a review from addaleax July 15, 2023 17:45
daeyeon added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 31, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2023

Copy link
Copy Markdown
Collaborator

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
nodejs-github-bot merged commit 54e4f1f into nodejs:main Aug 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 54e4f1f

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
PR-URL: #48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
CGQAQ deleted the src-fix-callback_queue-missing-header branch August 16, 2023 08:20
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL