FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: expand on squashing and rebasing to land a PR by legendecas · Pull Request #48751 · nodejs/node · GitHub

/ node Public

doc: expand on squashing and rebasing to land a PR - #48751

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
legendecas:docs/pr-rebase
Jul 15, 2023
ConversationCommits (4)ChecksFiles changed
Merged

doc: expand on squashing and rebasing to land a PR#48751
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
legendecas:docs/pr-rebase

Conversation

legendecas commented Jul 13, 2023

Copy link
Copy Markdown
Member

Document the choice of squashing and rebasing when landing a pull request containing more than one subsystem commits.

Refs: #47956 (comment)

nodejs-github-bot commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 13, 2023
RafaelGSS reviewed Jul 13, 2023
View reviewed changes
Comment thread doc/contributing/collaborator-guide.md Outdated
MoLow approved these changes Jul 13, 2023
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. should we mention the corresponding commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels?

aduh95 reviewed Jul 13, 2023
View reviewed changes
Comment thread doc/contributing/collaborator-guide.md Outdated
aduh95 reviewed Jul 13, 2023
View reviewed changes
Comment thread doc/contributing/collaborator-guide.md Outdated
aduh95 reviewed Jul 13, 2023
View reviewed changes
Comment thread doc/contributing/collaborator-guide.md Outdated
lpinca added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 14, 2023
mhdawson approved these changes Jul 14, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 14, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2023
nodejs-github-bot merged commit 5da84a6 into nodejs:main Jul 15, 2023

nodejs-github-bot commented Jul 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5da84a6

legendecas deleted the docs/pr-rebase branch July 19, 2023 03:14
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: expand on squashing and rebasing to land a PR
faf73fe 
PR-URL: nodejs#48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: expand on squashing and rebasing to land a PR
b219e5c 
PR-URL: nodejs#48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
doc: expand on squashing and rebasing to land a PR
21b8202 
PR-URL: nodejs#48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
doc: expand on squashing and rebasing to land a PR
ea54784 
PR-URL: #48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 12, 2023
doc: expand on squashing and rebasing to land a PR
cb565ee 
PR-URL: #48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
doc: expand on squashing and rebasing to land a PR
10495ad 
PR-URL: #48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno mentioned this pull request Sep 13, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
doc: expand on squashing and rebasing to land a PR
d3041df 
PR-URL: #48751
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
MoLow MoLow approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL