doc: node inspect port 0 description when help is printed - #48785
Merged
aduh95 merged 1 commit intoAug 11, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cola119
approved these changes
Jul 18, 2023
Copy link
Copy Markdown
Member
|
@iloveitaly Could you update the commit message to be <= 72 columns? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I wonder if we should also add this and the other options to doc/api/debugger.md. |
Sorry, something went wrong.
lpinca
approved these changes
Jul 20, 2023
aymen94
approved these changes
Jul 25, 2023
this is not clearly documented anywhere and is an incredibly helpful tool for CLI debugging.
iloveitaly
force-pushed
the
docs-inspect-port
branch
from
4cafd24 to
8b1f056
Compare
July 27, 2023 19:24
Copy link
Copy Markdown
Contributor
Author
|
@cola119 commit msg line size is fixed! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@cola119 quick reminder on this one! |
Sorry, something went wrong.
cola119
approved these changes
Aug 7, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48785 ✔ Done loading data for nodejs/node/pull/48785 ----------------------------------- PR info ------------------------------------ Title doc: node inspect port 0 description when help is printed (#48785) Author Michael Bianco (@iloveitaly, first-time contributor) Branch iloveitaly:docs-inspect-port -> nodejs:main Labels author ready, needs-ci, debugger Commits 1 - doc: node inspect port 0 description when help is printed Committers 1 - Michael Bianco PR-URL: https://github.com/nodejs/node/pull/48785 Reviewed-By: Kohei Ueno Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48785 Reviewed-By: Kohei Ueno Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 15 Jul 2023 15:22:15 GMT ✔ Approvals: 2 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/48785#pullrequestreview-1565021811 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48785#pullrequestreview-1539989751 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5783927533 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5785309084 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48785 ✔ Done loading data for nodejs/node/pull/48785 ----------------------------------- PR info ------------------------------------ Title doc: node inspect port 0 description when help is printed (#48785) Author Michael Bianco (@iloveitaly, first-time contributor) Branch iloveitaly:docs-inspect-port -> nodejs:main Labels author ready, request-ci, debugger Commits 1 - doc: node inspect port 0 description when help is printed Committers 1 - Michael Bianco PR-URL: https://github.com/nodejs/node/pull/48785 Reviewed-By: Kohei Ueno Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48785 Reviewed-By: Kohei Ueno Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 15 Jul 2023 15:22:15 GMT ✔ Approvals: 2 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/48785#pullrequestreview-1565021811 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48785#pullrequestreview-1539989751 ✘ GitHub CI is still running ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5815735261 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
29 tasks
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 16, 2023
PR-URL: #48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48785 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is not clearly documented anywhere and is an incredibly helpful tool for CLI debugging.