FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: fix async callback in describe not awaited by rluvaton · Pull Request #48856 · nodejs/node · GitHub

/ node Public

test_runner: fix async callback in describe not awaited - #48856

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
rluvaton:fix/async-callback-in-describe-not-awaited
Jul 23, 2023
ConversationCommits (6)ChecksFiles changed
Merged

test_runner: fix async callback in describe not awaited#48856
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
rluvaton:fix/async-callback-in-describe-not-awaited

Conversation

rluvaton commented Jul 20, 2023

Copy link
Copy Markdown
Member

fix #48845

nodejs-github-bot commented Jul 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 20, 2023
MoLow approved these changes Jul 20, 2023
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023

nodejs-github-bot commented Jul 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52881/

atlowChemi added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 21, 2023
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2023
nodejs-github-bot merged commit 44b8a06 into nodejs:main Jul 23, 2023

nodejs-github-bot commented Jul 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 44b8a06

rluvaton deleted the fix/async-callback-in-describe-not-awaited branch July 23, 2023 10:31
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
test_runner: fix async callback in describe not awaited
697974b 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: fix async callback in describe not awaited
ecee4c4 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: fix async callback in describe not awaited
2932125 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
test_runner: fix async callback in describe not awaited
6dae4f7 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
test_runner: fix async callback in describe not awaited
65d2394 
PR-URL: #48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
atlowChemi mentioned this pull request Sep 30, 2023
Closed
targos pushed a commit that referenced this pull request Oct 28, 2023
test_runner: fix async callback in describe not awaited
6b186d4 
PR-URL: #48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: fix async callback in describe not awaited
0ae24b6 
PR-URL: nodejs/node#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: fix async callback in describe not awaited
f2b9368 
PR-URL: nodejs/node#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test runner: async callbacks passed to describe are note awaited

5 participants

Back | FazBrowse Home | New Git URL