FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: change duration to duration_ms on test documentation by arxngr · Pull Request #48892 · nodejs/node · GitHub

/ node Public

doc: change duration to duration_ms on test documentation - #48892

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
arxngr:doc-rename-duration-to-duration_ns
Jul 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: change duration to duration_ms on test documentation#48892
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
arxngr:doc-rename-duration-to-duration_ns

Conversation

arxngr commented Jul 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

change duration to duration_ms in test documentation

Fixes: #48887

nodejs-github-bot commented Jul 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jul 23, 2023
arxngr changed the title doc:change duration to duration_ns on test documentation doc:change duration to duration_ms on test documentation Jul 23, 2023
aduh95 approved these changes Jul 23, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

arxngr changed the title doc:change duration to duration_ms on test documentation doc: change duration to duration_ms on test documentation Jul 23, 2023

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

sure :)

arxngr force-pushed the doc-rename-duration-to-duration_ns branch from 3afbda0 to c8faff2 Compare July 23, 2023 13:36

koshic commented Jul 23, 2023

Copy link
Copy Markdown

@0xArdi-N plz don't forget about test:fail

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

@0xArdi-N plz don't forget about test:fail

on it

arxngr force-pushed the doc-rename-duration-to-duration_ns branch from c8faff2 to a20a7c8 Compare July 23, 2023 13:41

deokjinkim commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

arxngr force-pushed the doc-rename-duration-to-duration_ns branch from a20a7c8 to 9eca9da Compare July 23, 2023 14:24

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

hi @deokjinkim , I'm already fixed that. :)

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2023
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 24, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
nodejs-github-bot merged commit 71165e1 into nodejs:main Jul 25, 2023

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 71165e1

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
doc: change duration to duration_ms on test documentation
aa61915 
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: change duration to duration_ms on test documentation
7f78f2c 
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
doc: change duration to duration_ms on test documentation
711ccd0 
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
doc: change duration to duration_ms on test documentation
bc751ed 
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
doc: change duration to duration_ms on test documentation
d130e6f 
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
doc: change duration to duration_ms on test documentation
092f9fe 
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
doc: change duration to duration_ms on test documentation
e8a32fb 
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: change duration to duration_ms on test documentation
64267bc 
PR-URL: nodejs/node#48892
Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: change duration to duration_ms on test documentation
21be215 
PR-URL: nodejs/node#48892
Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
MoLow MoLow approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms'

10 participants

Back | FazBrowse Home | New Git URL