lib,permission: drop repl autocomplete when pm enabled - #48920
Merged
nodejs-github-bot merged 1 commit intoJul 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
missing tests |
Sorry, something went wrong.
tniessen
reviewed
Jul 25, 2023
Comment thread
lib/internal/repl/utils.js
Outdated
targos
previously requested changes
Jul 25, 2023
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think it would be more correct to update the condition in
node/lib/internal/util/inspector.js
Line 49 in 36c72c8
The REPL already handles the error case (when Node.js is built without inspector support)
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ShogunPanda
approved these changes
Jul 26, 2023
Trott
reviewed
Jul 26, 2023
Comment thread
lib/internal/util/inspector.js
Trott
approved these changes
Jul 26, 2023
tniessen
approved these changes
Jul 27, 2023
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jul 27, 2023
PR-URL: nodejs#48920 Fixes: nodejs#48884 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48920 Fixes: nodejs#48884 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48920 Fixes: nodejs#48884 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48920 Fixes: nodejs#48884 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48884
I'll add some tests for it