FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

watch: use debounce instead of throttle by MoLow · Pull Request #48926 · nodejs/node · GitHub

/ node Public

watch: use debounce instead of throttle - #48926

Closed
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:watch-mode-debounce
ConversationCommits (2)ChecksFiles changed
Closed

watch: use debounce instead of throttle#48926
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:watch-mode-debounce

Conversation

MoLow commented Jul 25, 2023

Copy link
Copy Markdown
Member

Fixes #48909

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 25, 2023
MoLow added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. watch-mode Issues and PRs related to watch mode labels Jul 25, 2023
MoLow requested review from atlowChemi and benjamingr July 25, 2023 20:29
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52931/

MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2023

nodejs-github-bot commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 761f568...48345d0

nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2023
watch: use debounce instead of throttle
b814de6 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2023
watch: decrease debounce rate
48345d0 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MoLow deleted the watch-mode-debounce branch July 27, 2023 20:45
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
watch: use debounce instead of throttle
f24ccac 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
watch: decrease debounce rate
87c6d94 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
watch: use debounce instead of throttle
3280f71 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
watch: decrease debounce rate
985b603 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
watch: use debounce instead of throttle
2088ba8 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
watch: decrease debounce rate
ce18807 
PR-URL: nodejs#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
watch: use debounce instead of throttle
4945534 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
watch: decrease debounce rate
51666e1 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
watch: use debounce instead of throttle
a129962 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
watch: decrease debounce rate
b79b292 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 28, 2023
watch: use debounce instead of throttle
83a6d20 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 28, 2023
watch: decrease debounce rate
f27d505 
PR-URL: #48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
watch: use debounce instead of throttle
13c0f36 
PR-URL: nodejs/node#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
watch: decrease debounce rate
9aa5d44 
PR-URL: nodejs/node#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
watch: use debounce instead of throttle
4235512 
PR-URL: nodejs/node#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
watch: decrease debounce rate
1e13dda 
PR-URL: nodejs/node#48926
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

iliakan commented Sep 9, 2024

Copy link
Copy Markdown

Thank you! I wonder is it possible to specify a custom debounce value (instead of 200) somehow? As a CLI option perhaps?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
trivikr trivikr approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. watch-mode Issues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--watch not running with last file content when file changes multiple times

7 participants

Back | FazBrowse Home | New Git URL