FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix snapshot tests when cwd contains spaces or backslashes by aduh95 · Pull Request #48959 · nodejs/node · GitHub

/ node Public

test: fix snapshot tests when cwd contains spaces or backslashes - #48959

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:snapshot-special-chars
Jul 31, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: fix snapshot tests when cwd contains spaces or backslashes#48959
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:snapshot-special-chars

Conversation

aduh95 commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

Both are valid characters for file names on non-Windows systems.

test: fix snapshot tests when cwd contains spaces or backslashes
19a573a 
Both are valid characters for file names on non-Windows systems.
aduh95 requested a review from MoLow July 29, 2023 09:24
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 29, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2023

nodejs-github-bot commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52996/

nodejs-github-bot commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53000/

nodejs-github-bot commented Jul 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53022/

nodejs-github-bot commented Jul 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53026/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
nodejs-github-bot merged commit 217abd4 into nodejs:main Jul 31, 2023

nodejs-github-bot commented Jul 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in 217abd4

aduh95 deleted the snapshot-special-chars branch July 31, 2023 22:11
This was referenced Aug 1, 2023
Open
Open
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
61e857e 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs#48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
b8a4981 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs#48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
a78156e 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs#48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
db632d5 
Both are valid characters for file names on non-Windows systems.

PR-URL: #48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
931bb1e 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs#48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
b4ca4a6 
Both are valid characters for file names on non-Windows systems.

PR-URL: #48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
ce1d396 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs#48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
test: fix snapshot tests when cwd contains spaces or backslashes
3424793 
Both are valid characters for file names on non-Windows systems.

PR-URL: #48959
Backport-PR-URL: #50669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: fix snapshot tests when cwd contains spaces or
4d632c9 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs/node#48959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: fix snapshot tests when cwd contains spaces or
dff1073 
Both are valid characters for file names on non-Windows systems.

PR-URL: nodejs/node#48959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL