FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: order `common.mjs` imports and exports in ASCII order by aduh95 · Pull Request #48960 · nodejs/node · GitHub

/ node Public

test: order common.mjs imports and exports in ASCII order - #48960

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:common-ascii
Jul 31, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: order common.mjs imports and exports in ASCII order#48960
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:common-ascii

Conversation

aduh95 commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

The current arbitrary order makes it hard to browse the file IMO.

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 29, 2023

github-actions Bot commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 29, 2023
aduh95 changed the title test: order common.mjs in ASCII order test: order common.mjs imports and exports in ASCII order Jul 29, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2023

nodejs-github-bot commented Jul 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52976/

nodejs-github-bot commented Jul 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52979/

nodejs-github-bot commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52999/

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jul 31, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
nodejs-github-bot merged commit 97ca9a8 into nodejs:main Jul 31, 2023

nodejs-github-bot commented Jul 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in 97ca9a8

aduh95 deleted the common-ascii branch July 31, 2023 13:13
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: order common.mjs in ASCII order
b09b6aa 
PR-URL: nodejs#48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: order common.mjs in ASCII order
48504a8 
PR-URL: nodejs#48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
test: order common.mjs in ASCII order
c94301f 
PR-URL: nodejs#48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
test: order common.mjs in ASCII order
0290d5c 
PR-URL: #48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
test: order common.mjs in ASCII order
6b6a2c0 
PR-URL: nodejs#48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
test: order common.mjs in ASCII order
d4398d4 
PR-URL: #48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: order common.mjs in ASCII order
9d44275 
PR-URL: nodejs#48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
test: order common.mjs in ASCII order
a9347a4 
PR-URL: #48960
Backport-PR-URL: #50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: order common.mjs in ASCII order
36e65b4 
PR-URL: nodejs/node#48960
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: order common.mjs in ASCII order
4e1ce26 
PR-URL: nodejs/node#48960
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
tniessen tniessen approved these changes
MoLow MoLow approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL