test: remove --no-warnings flag in test_runner fixtures - #48989
Merged
nodejs-github-bot merged 1 commit intoAug 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
no longer needed after nodejs#48915 fix
MoLow
approved these changes
Aug 2, 2023
MoLow
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
atlowChemi
approved these changes
Aug 2, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Seems unrelated can you please retry? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
29 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
25 tasks
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Copy link
Copy Markdown
Member
|
Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport. Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
rluvaton
added a commit
to rluvaton/node
that referenced
this pull request
Sep 4, 2023
no longer needed after nodejs#48915 fix PR-URL: nodejs#48989 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
no longer needed after #48915 fix PR-URL: nodejs/node#48989 Backport-PR-URL: nodejs/node#49225 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
no longer needed after #48915 fix PR-URL: nodejs/node#48989 Backport-PR-URL: nodejs/node#49225 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no longer needed after #48915 fix