FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use `fixtures.fileURL` when appropriate by aduh95 · Pull Request #48990 · nodejs/node · GitHub

/ node Public

test: use fixtures.fileURL when appropriate - #48990

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fixtures-fileURL
Aug 3, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: use fixtures.fileURL when appropriate#48990
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fixtures-fileURL

Conversation

aduh95 commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 1, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023

nodejs-github-bot commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53035/

nodejs-github-bot commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53044/

nodejs-github-bot commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53046/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2023
github-actions Bot mentioned this pull request Aug 3, 2023
Open
29 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2023
nodejs-github-bot merged commit a061781 into nodejs:main Aug 3, 2023

nodejs-github-bot commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in a061781

aduh95 deleted the fixtures-fileURL branch August 3, 2023 21:40
github-actions Bot mentioned this pull request Aug 4, 2023
Open
25 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: use fixtures.fileURL when appropriate
90e2d55 
PR-URL: nodejs#48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: use fixtures.fileURL when appropriate
36e2371 
PR-URL: nodejs#48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
test: use fixtures.fileURL when appropriate
578c964 
PR-URL: nodejs#48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
test: use fixtures.fileURL when appropriate
a8ab5b6 
PR-URL: #48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
test: use fixtures.fileURL when appropriate
9aff47c 
PR-URL: nodejs#48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
test: use fixtures.fileURL when appropriate
6c3e5c4 
PR-URL: #48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: use fixtures.fileURL when appropriate
3d58e49 
PR-URL: nodejs#48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
test: use fixtures.fileURL when appropriate
d5a1153 
PR-URL: #48990
Backport-PR-URL: #50669
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: use fixtures.fileURL when appropriate
e3dd46f 
PR-URL: nodejs/node#48990
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: use fixtures.fileURL when appropriate
525fba9 
PR-URL: nodejs/node#48990
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL