FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: added website team to sharing project news by UlisesGascon · Pull Request #49002 · nodejs/node · GitHub

/ node Public

docs: added website team to sharing project news - #49002

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
UlisesGascon:UlisesGascon-patch-1
Feb 27, 2024
ConversationCommits (1)ChecksFiles changed
Merged

docs: added website team to sharing project news#49002
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
UlisesGascon:UlisesGascon-patch-1

Conversation

UlisesGascon commented Aug 3, 2023

Copy link
Copy Markdown
Member

cc: @nodejs/next-10

nodejs-github-bot commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2023
UlisesGascon mentioned this pull request Aug 3, 2023
Merged
UlisesGascon marked this pull request as ready for review August 3, 2023 06:34

aduh95 commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Can you fix the commit message please? It should start with an imperative verb (i.e. s/added/add/) per

node/doc/contributing/pull-requests.md

Lines 168 to 175 in 260092e

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.
Examples:
* `net: add localAddress and localPort to Socket`
* `src: fix typos in async_wrap.h`

mhdawson approved these changes Aug 3, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson approved these changes Nov 17, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Nov 17, 2023

Copy link
Copy Markdown
Member

@UlisesGascon can you squash to 1 commit? I think that would fix the remaing CI complaint.

UlisesGascon force-pushed the UlisesGascon-patch-1 branch 2 times, most recently from 10e4a31 to 1891929 Compare February 26, 2024 08:53

UlisesGascon commented Feb 26, 2024

Copy link
Copy Markdown
Member Author

I forgot this PR for a while, I just updated the branch with the last changes from main and clean up the historial, so now I think that is fine 👍

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
nodejs-github-bot merged commit f28ccd3 into nodejs:main Feb 27, 2024

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

Landed in f28ccd3

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
doc: add website team to sharing project news
2cdfe35 
PR-URL: #49002
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
doc: add website team to sharing project news
a74c373 
PR-URL: #49002
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
legendecas legendecas approved these changes
+3 more reviewers
wesleytodd wesleytodd approved these changes
mhdawson mhdawson approved these changes
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL