test: add and use expectSyncExitWithoutError() and expectSyncExit() utils - #49020
Closed
joyeecheung wants to merge 2 commits into
Closed
test: add and use expectSyncExitWithoutError() and expectSyncExit() utils#49020joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Many of our tests that launch child processes only check the status of them without additional logging so when they fail, usually what you see from a assert.strictEqual(child.status, 0) is only: Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 1 !== 0 and without changing the code to do additional logging it's usually impossible to understand exactly what's causing the failure. this is especially troublesome when debugging flaky tests in the CI. So my hope is that we can also gradually use these methods instead of doing assert.strictEqual(child.status, 0) right after launching child processes in the tests.... |
Sorry, something went wrong.
VoltrexKeyva
reviewed
Aug 5, 2023
Comment thread
test/common/README.md
Outdated
lpinca
approved these changes
Aug 8, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
22 tasks
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures.
..and replace the similar code added for logging.
24 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Aug 16, 2023
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: #49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Aug 16, 2023
..and replace the similar code added for logging. PR-URL: #49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
26 tasks
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: #49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
..and replace the similar code added for logging. PR-URL: #49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: #49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: nodejs/node#49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: nodejs/node#49020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add expectSyncExitWithoutError() and expectSyncExit() utils
These can be used to check the state and the output of a child
process launched with spawnSync(). They log additional information
about the child process when the check fails to facilitate debugging
test failures.
test: use expectSyncExit{WithErrors} in snapshot tests
..and replace the similar code added for logging.