FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use ARES_SUCCESS instead of 0 by pluris · Pull Request #49048 · nodejs/node · GitHub

/ node Public

src: use ARES_SUCCESS instead of 0 - #49048

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/return_value_ares
Aug 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: use ARES_SUCCESS instead of 0#49048
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/return_value_ares

Conversation

pluris commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Added missing changes in the PR.
Refs : #48834

nodejs-github-bot commented Aug 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Aug 7, 2023
mcollina approved these changes Aug 8, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023

nodejs-github-bot commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53105/

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53190/

deokjinkim added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 11, 2023

nodejs-github-bot commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53214/

nodejs-github-bot commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53251/

nodejs-github-bot commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53254/

github-actions Bot mentioned this pull request Aug 13, 2023
Open
29 tasks

nodejs-github-bot commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53275/

nodejs-github-bot commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53294/

This was referenced Aug 14, 2023
Open
Open

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53339/

github-actions Bot mentioned this pull request Aug 16, 2023
Open
24 tasks
deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2023

nodejs-github-bot commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53377/

github-actions Bot mentioned this pull request Aug 17, 2023
Open
26 tasks

nodejs-github-bot commented Aug 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53401/

github-actions Bot mentioned this pull request Aug 18, 2023
Open
32 tasks
pluris force-pushed the fix/return_value_ares branch from b39c68a to a50acf8 Compare August 18, 2023 04:22
deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023

nodejs-github-bot commented Aug 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53420/

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53456/

deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2023

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49048
✔  Done loading data for nodejs/node/pull/49048
----------------------------------- PR info ------------------------------------
Title      src: use ARES_SUCCESS instead of 0 (#49048)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     pluris:fix/return_value_ares -> nodejs:main
Labels     c++, cares, author ready, needs-ci
Commits    1
 - src: use ARES_SUCCESS instead of 0
Committers 1
 - pluris 
PR-URL: https://github.com/nodejs/node/pull/49048
Refs: https://github.com/nodejs/node/pull/48834
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Deokjin Kim 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49048
Refs: https://github.com/nodejs/node/pull/48834
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Deokjin Kim 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: use ARES_SUCCESS instead of 0
   ℹ  This PR was created on Mon, 07 Aug 2023 02:09:49 GMT
   ✔  Approvals: 5
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/49048#pullrequestreview-1564608652
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49048#pullrequestreview-1566030900
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49048#pullrequestreview-1566746791
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/49048#pullrequestreview-1569578439
   ✔  - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/49048#pullrequestreview-1573692692
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-08-20T03:14:04Z: https://ci.nodejs.org/job/node-test-pull-request/53456/
- Querying data for job/node-test-pull-request/53456/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5916677346

deokjinkim removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 20, 2023
deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023
nodejs-github-bot merged commit 982e7a6 into nodejs:main Aug 20, 2023

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 982e7a6

This was referenced Aug 21, 2023
Open
Open
Open
pluris deleted the fix/return_value_ares branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
src: use ARES_SUCCESS instead of 0
f2552a4 
PR-URL: #49048
Refs: #48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
src: use ARES_SUCCESS instead of 0
158c91a 
PR-URL: #49048
Refs: #48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
src: use ARES_SUCCESS instead of 0
534aa0e 
PR-URL: nodejs/node#49048
Refs: nodejs/node#48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
src: use ARES_SUCCESS instead of 0
59cf0e0 
PR-URL: nodejs/node#49048
Refs: nodejs/node#48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
lpinca lpinca approved these changes
deokjinkim deokjinkim approved these changes
daeyeon daeyeon approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL