FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

esm: protect `ERR_UNSUPPORTED_DIR_IMPORT` against prototype pollution by aduh95 · Pull Request #49060 · nodejs/node · GitHub

/ node Public

esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution - #49060

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:ERR_UNSUPPORTED_DIR_IMPORT
Aug 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution#49060
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:ERR_UNSUPPORTED_DIR_IMPORT

Conversation

aduh95 commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot commented Aug 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 7, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 8, 2023
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 8, 2023

github-actions Bot commented Aug 8, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✘  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/5794964446

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Aug 8, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023

nodejs-github-bot commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53104/

nodejs-github-bot commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53119/

nodejs-github-bot commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53153/

github-actions Bot mentioned this pull request Aug 11, 2023
Open
29 tasks

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53161/

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53166/

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Aug 11, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
nodejs-github-bot merged commit 6aafb6f into nodejs:main Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6aafb6f

aduh95 deleted the ERR_UNSUPPORTED_DIR_IMPORT branch August 11, 2023 07:00
github-actions Bot mentioned this pull request Aug 13, 2023
Open
29 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
f5c7e91 
PR-URL: nodejs#49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
1f60532 
PR-URL: nodejs#49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
d3807a1 
PR-URL: #49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
3e9ac48 
PR-URL: nodejs#49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
f23b2a3 
PR-URL: #49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
61aa405 
PR-URL: nodejs#49060
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution
385f24c 
PR-URL: #49060
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype
5826083 
PR-URL: nodejs/node#49060
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype
0c20c75 
PR-URL: nodejs/node#49060
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
JakobJingleheimer JakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL