FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: improve WebStreams creation performance by rluvaton · Pull Request #49089 · nodejs/node · GitHub

/ node Public

stream: improve WebStreams creation performance - #49089

Merged
nodejs-github-bot merged 9 commits into
nodejs:mainfrom
rluvaton:improve-webstream-perf
Aug 13, 2023
ConversationCommits (9)ChecksFiles changed
Merged

stream: improve WebStreams creation performance#49089
nodejs-github-bot merged 9 commits into
nodejs:mainfrom
rluvaton:improve-webstream-perf

Conversation

rluvaton commented Aug 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

From my local tests, this improves the benchmark/webstreams/creation.js by 2 to 3 times

could someone please run the benchmark in the CI

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Aug 9, 2023

Xstoudi commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

Ubuntu on WSL2

Without the change:

webstreams/creation.js kind="ReadableStream" n=50000: 245,842.89135667187
webstreams/creation.js kind="TransformStream" n=50000: 64,412.45274303109
webstreams/creation.js kind="WritableStream" n=50000: 235,646.29630427333

With change:

webstreams/creation.js kind="ReadableStream" n=50000: 796,678.8307839505
webstreams/creation.js kind="TransformStream" n=50000: 137,357.95549408294
webstreams/creation.js kind="WritableStream" n=50000: 503,433.1675202359

If values are rates and not times, your change seems to improve it on my end too!

debadree25 commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

Seems to be failing a lot of WPTs too

debadree25 reviewed Aug 10, 2023
View reviewed changes
Comment thread lib/internal/webstreams/readablestream.js Outdated
rluvaton changed the title stream: improve WebStreams performance stream: improve WebStreams creation performance Aug 10, 2023

rluvaton commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

https://github.com/nodejs/node/blob/52d32bdfbd88d7abd19365daad07b7e7c9f423fd/test/fixtures/wpt/streams/idlharness.any.js test fail, anyone knows why?

Edit: fixed the tests

mcollina commented Aug 10, 2023

Copy link
Copy Markdown
Member

cc @jasnell

rluvaton force-pushed the improve-webstream-perf branch from 4bb72eb to ede6c54 Compare August 10, 2023 17:11

rluvaton commented Aug 10, 2023

Copy link
Copy Markdown
Member Author

fixed the tests

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53181/

anonrig added needs-benchmark-ci PR that need a benchmark CI run. performance Issues and PRs related to the performance of Node.js. labels Aug 11, 2023

anonrig commented Aug 11, 2023

Copy link
Copy Markdown
Member

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1358/

rluvaton commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

benchmark output:

                                                       confidence improvement accuracy (*)   (**)   (***)
webstreams/creation.js kind='ReadableStream' n=50000         ***    144.39 %       ±6.00% ±8.00% ±10.45%
webstreams/creation.js kind='TransformStream' n=50000        ***     98.61 %       ±3.81% ±5.11%  ±6.72%
webstreams/creation.js kind='WritableStream' n=50000         ***     85.25 %       ±6.30% ±8.44% ±11.08%
 
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 3 comparisons, you can thus
expect the following amount of false-positive results:
  0.15 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.03 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

mcollina approved these changes Aug 11, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53203/

rluvaton commented Aug 12, 2023

Copy link
Copy Markdown
Member Author

Can you please retry the CI, the tests seems to be flaky

atlowChemi commented Aug 12, 2023

Copy link
Copy Markdown
Member

Can you please retry the CI, the tests seems to be flaky

Most of the failures are related to #49059 (comment)

nodejs-github-bot commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53244/

nodejs-github-bot commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53249/

github-actions Bot mentioned this pull request Aug 13, 2023
Open
29 tasks

nodejs-github-bot commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53264/

atlowChemi added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 13, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
nodejs-github-bot merged commit 9fc5700 into nodejs:main Aug 13, 2023

nodejs-github-bot commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9fc5700

rluvaton deleted the improve-webstream-perf branch August 13, 2023 08:56
github-actions Bot mentioned this pull request Aug 14, 2023
Open
25 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
stream: improve WebStreams performance
8d47964 
PR-URL: nodejs#49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
github-actions Bot mentioned this pull request Aug 15, 2023
Open
22 tasks
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
stream: improve WebStreams performance
46a1fe9 
PR-URL: #49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
stream: improve WebStreams performance
5d73a58 
PR-URL: nodejs#49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
stream: improve WebStreams performance
e87ce4b 
PR-URL: #49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
stream: improve WebStreams performance
600c08d 
PR-URL: #49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
leeoniya mentioned this pull request Sep 5, 2023
Open
rluvaton mentioned this pull request Sep 11, 2023
Open
targos pushed a commit that referenced this pull request Nov 27, 2023
stream: improve WebStreams performance
d585d13 
PR-URL: #49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
stream: improve WebStreams performance
30d3968 
PR-URL: nodejs/node#49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
stream: improve WebStreams performance
d719ef1 
PR-URL: nodejs/node#49089
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
+1 more reviewer
debadree25 debadree25 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL