FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

node-api: fix compiler warning in node_api.h by graebm · Pull Request #49103 · nodejs/node · GitHub

/ node Public

node-api: fix compiler warning in node_api.h - #49103

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
graebm:fix-strict-prototypes
Aug 30, 2023
ConversationCommits (1)ChecksFiles changed
Merged

node-api: fix compiler warning in node_api.h#49103
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
graebm:fix-strict-prototypes

Conversation

graebm commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix -Wstrict-prototypes warning from AppleClang 14.0.3.14030022, compiling C.

My team tests our C addon with -Werror and recent changes to node_api.h broke our build.

/Users/runner/.cmake-js/node-arm64/v18.17.0/include/node/node_api.h:33:65: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void

The break started when the build machines started using node v18.17.0. Builds from a week ago, using node v18.16.1 were successful.

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 11, 2023
mhdawson approved these changes Aug 14, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023

nodejs-github-bot commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53322/

node-api: fix compiler warning in node_api.h
9d6783c 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.
graebm force-pushed the fix-strict-prototypes branch from e2f7a0e to 9d6783c Compare August 14, 2023 18:10
This was referenced Aug 15, 2023
Open
Open
Open
Open
gabrielschulhof approved these changes Aug 18, 2023
View reviewed changes

gabrielschulhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

graebm commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

Seems like some tests are being flaky. Should I push an empty commit and force tests to re-run? Or wait for someone else to take care of things?

legendecas approved these changes Aug 20, 2023
View reviewed changes

legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your contribution!

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53467/

This was referenced Aug 21, 2023
Open
Open

nodejs-github-bot commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53494/

github-actions Bot mentioned this pull request Aug 23, 2023
Open
27 tasks

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53526/

This was referenced Aug 24, 2023
Open
Open
Open
Open
Open
github-actions Bot mentioned this pull request Aug 29, 2023
Open
21 tasks

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53619/

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53624/

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023
nodejs-github-bot merged commit 9848352 into nodejs:main Aug 30, 2023

nodejs-github-bot commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9848352

graebm deleted the fix-strict-prototypes branch August 30, 2023 15:13
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
node-api: fix compiler warning in node_api.h
7a80834 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: #49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon mentioned this pull request Sep 10, 2023
Merged
toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Sep 14, 2023
nodejs/node#49103
d7cc080
targos pushed a commit that referenced this pull request Nov 27, 2023
node-api: fix compiler warning in node_api.h
48a1b93 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: #49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
node-api: fix compiler warning in node_api.h
df9cf52 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: nodejs/node#49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
node-api: fix compiler warning in node_api.h
3876210 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: nodejs/node#49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gabrielschulhof gabrielschulhof approved these changes
legendecas legendecas approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL