test_runner: reland run global after() hook earlier by cjihrig · Pull Request #49116 · nodejs/node · GitHub

This commit reverts the revert in
bb52656. It also includes the fix for the issue that required the revert
(#49059 (comment)) and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110

Review requested:

@nodejs/test_runner

lgtm

CI: https://ci.nodejs.org/job/node-test-pull-request/53242/

CI: https://ci.nodejs.org/job/node-test-pull-request/53243/

CI: https://ci.nodejs.org/job/node-test-pull-request/53248/

CI: https://ci.nodejs.org/job/node-test-pull-request/53250/ 🟡

why not await?

@rluvaton postRun returns void (and not a Promise)

I thought I changed that (or I'm thinking of another function there) 😅

Landed in b574075

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

Backport PR:

[v20.x backport] backport multiple test runner related prs #49225

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Backport-PR-URL: #49225 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs/node#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs/node#49059 Refs: nodejs/node#49110 PR-URL: nodejs/node#49116 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

test_runner: reland run global after() hook earlier

6796570

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110

cjihrig requested review from MoLow, atlowChemi, benjamingr and mcollina August 12, 2023 14:18

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 12, 2023

mcollina approved these changes Aug 12, 2023

View reviewed changes

atlowChemi approved these changes Aug 12, 2023

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

atlowChemi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 12, 2023

MoLow approved these changes Aug 12, 2023

View reviewed changes

github-actions Bot mentioned this pull request Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

29 tasks

cjihrig removed the needs-ci PRs that need a full CI run. label Aug 13, 2023

benjamingr approved these changes Aug 13, 2023

View reviewed changes

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023

rluvaton reviewed Aug 13, 2023

View reviewed changes

github-actions Bot mentioned this pull request Aug 14, 2023

CI Reliability 2023-08-14 nodejs/reliability#636

Open

25 tasks

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2023

nodejs-github-bot merged commit b574075 into nodejs:main Aug 14, 2023

github-actions Bot mentioned this pull request Aug 15, 2023

CI Reliability 2023-08-15 nodejs/reliability#637

Open

22 tasks

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

cjihrig deleted the reland branch August 17, 2023 16:52

RafaelGSS added the backport-requested-v20.x label Aug 17, 2023

rluvaton mentioned this pull request Aug 18, 2023

[v20.x backport] backport multiple test runner related prs #49225

Closed

rluvaton added backport-open-v20.x and removed backport-requested-v20.x labels Aug 18, 2023

UlisesGascon mentioned this pull request Sep 10, 2023

v20.7.0 proposal #49592

Merged

targos added backported-to-v20.x and removed backport-open-v20.x labels Nov 12, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

-                const exitHandler = async () => {
-                  await root.run(new ERR_TEST_FAILURE(
+                const exitHandler = () => {
+                  root.postRun(new ERR_TEST_FAILURE(

test_runner: reland run global after() hook earlier by cjihrig · Pull Request #49116 · nodejs/node · GitHub

Uh oh!

Uh oh!

test_runner: reland run global after() hook earlier - #49116

test_runner: reland run global after() hook earlier#49116
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:reland

cjihrig commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023 •
edited by cjihrig
Loading

Uh oh!

Uh oh!

rluvaton Aug 13, 2023

Uh oh!

atlowChemi Aug 13, 2023

Uh oh!

rluvaton Aug 13, 2023

Uh oh!

nodejs-github-bot commented Aug 14, 2023

Uh oh!

RafaelGSS commented Aug 17, 2023

Uh oh!

rluvaton commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

test_runner: reland run global after() hook earlier by cjihrig · Pull Request #49116 · nodejs/node · GitHub

Uh oh!

Uh oh!

test_runner: reland run global after() hook earlier - #49116

test_runner: reland run global after() hook earlier#49116nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom cjihrig:relandcjihrig/node:relandCopy head branch name to clipboard

Conversation

cjihrig commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

atlowChemi Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 14, 2023

Uh oh!

RafaelGSS commented Aug 17, 2023

Uh oh!

rluvaton commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

test_runner: reland run global after() hook earlier#49116
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:reland

nodejs-github-bot commented Aug 12, 2023 •
edited by cjihrig
Loading